From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E67C6FD1D for ; Mon, 20 Mar 2023 17:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231897AbjCTRdr (ORCPT ); Mon, 20 Mar 2023 13:33:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232736AbjCTRdW (ORCPT ); Mon, 20 Mar 2023 13:33:22 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF0D1258E for ; Mon, 20 Mar 2023 10:28:35 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id h9so12987840ljq.2 for ; Mon, 20 Mar 2023 10:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679333302; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wzjrze65UkFlGZ/XglOoMjwNcpTyBgOgHY9sMdnQEIs=; b=Vo3UGo2z4k6fUb8W5p5osgql1AL7hi17kd2Qs1xIaTXzfNK/6QLCaRE8d7pb7FRTKN hMtHp2NnJnj7UIhCyqIzEWooViz/Ynwxa/OXFJmy+rxcpzLB+PRpEFhAqo4ItYXuUw7B nHTwTvQlu+SzUnQlDuZxw2QVeTqgXw9Gb2/jdXlBZnjxxge83bAWqMTcsFoJ/KsOfT0q wQnVOW+jD6hA/qJkXENHffirUg2qgHSwRM4VN/cHBFMKepD/Y4i0KWBMpc5w3cpWKACK kpbpzMm3hQ3hzT4iICibYw+7qIaz9JkyIS87iBU3FMI2GcgR52FBqRz4Z0dGYvFpqLQT am/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679333302; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wzjrze65UkFlGZ/XglOoMjwNcpTyBgOgHY9sMdnQEIs=; b=Dn93/bb0vCSgdZ4CfD7ElCld+yHCx64wd8Vv8qgfzZg5LlATuhKx3wtaQ7FNE3mNBv YRyZru8O2DWhSHy4V+xrz8Le00+frhmQVf63P4K+YNOVZLDSAzhPcXUot5dwE3lIZPEm Y3xCy9VXKW6ZkZV2PU769i1u/fiN1tWOXZykieurc4sdiUbGJapYxAkwcgYaKLeA3i1R /Qn4KkZ2lDKs624HSFgO2P0aQP4KWnE+1aHPGS+vR2PZGekaKLLDrO1hSBsDbPOSEUEz u3SqDP6aBiqBscLLe17MvTxGbi8f4fBdxLC4eRGKLQ7Drfnjnkud5ZVpwkBwOD2pmlZz XdjQ== X-Gm-Message-State: AO0yUKUutc6S+7og5lowuqGzzgareoXVp4axb40rmbtgHwIxdPt3AA0h tLH8rBheorQ2BV86xi/t+3ywLA== X-Google-Smtp-Source: AK7set8SsF2uuzdimKsotO9xMkQAlOSI4YpsGaAyiASE6KgluVQej1fwQISQbDrsPr3/9l9EChJL3w== X-Received: by 2002:a2e:97c8:0:b0:298:9e64:c916 with SMTP id m8-20020a2e97c8000000b002989e64c916mr220941ljj.17.1679333302039; Mon, 20 Mar 2023 10:28:22 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id u9-20020ac248a9000000b004e966678db7sm1683101lfg.113.2023.03.20.10.28.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 10:28:21 -0700 (PDT) Message-ID: Date: Mon, 20 Mar 2023 18:28:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 12/15] arm64: dts: qcom: sa8775p: pmic: add thermal zones Content-Language: en-US To: Bartosz Golaszewski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski References: <20230320154841.327908-1-brgl@bgdev.pl> <20230320154841.327908-13-brgl@bgdev.pl> From: Konrad Dybcio In-Reply-To: <20230320154841.327908-13-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.03.2023 16:48, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the thermal zones and associated alarm nodes for the PMICs that have > them hooked up on sa8775p-ride. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 58 +++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > index 8616ead3daf5..276070b62ccd 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > @@ -6,6 +6,50 @@ > #include > #include > > +/ { > + thermal-zones { > + pmm8654au_1_thermal: pm8775-1-thermal { Please reindex this, downstream uses _1 for pmic@0, but this makes little sense. Make it match the SID. > + polling-delay-passive = <100>; > + polling-delay = <0>; > + thermal-sensors = <&pmm8654au_1_temp_alarm>; > + > + trips { > + trip0 { > + temperature = <105000>; > + hysteresis = <0>; > + type = "passive"; > + }; > + > + trip1 { > + temperature = <125000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + }; > + What happened to the downstream _2 (pmic@2) one and _4 (pmic@6)? Konrad > + pmm8654au_3_thermal: pm8775-3-thermal { > + polling-delay-passive = <100>; > + polling-delay = <0>; > + thermal-sensors = <&pmm8654au_3_temp_alarm>; > + > + trips { > + trip0 { > + temperature = <105000>; > + hysteresis = <0>; > + type = "passive"; > + }; > + > + trip1 { > + temperature = <125000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + }; > + }; > +}; > + > &spmi_bus { > pmm8654au_0: pmic@0 { > compatible = "qcom,pmm8654au", "qcom,spmi-pmic"; > @@ -41,6 +85,13 @@ pmm8654au_1: pmic@2 { > reg = <0x2 SPMI_USID>; > #address-cells = <1>; > #size-cells = <0>; > + > + pmm8654au_1_temp_alarm: temp-alarm@a00 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0xa00>; > + interrupts-extended = <&spmi_bus 0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; > + #thermal-sensor-cells = <0>; > + }; > }; > > pmm8654au_2: pmic@4 { > @@ -55,5 +106,12 @@ pmm8654au_3: pmic@6 { > reg = <0x6 SPMI_USID>; > #address-cells = <1>; > #size-cells = <0>; > + > + pmm8654au_3_temp_alarm: temp-alarm@a00 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0xa00>; > + interrupts-extended = <&spmi_bus 0x6 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; > + #thermal-sensor-cells = <0>; > + }; > }; > };