From: Nathan Fontenot <nathan.fontenot@amd.com>
To: Perry Yuan <Perry.Yuan@amd.com>,
rafael.j.wysocki@intel.com, ray.huang@amd.com,
viresh.kumar@linaro.org
Cc: Deepak.Sharma@amd.com, Mario.Limonciello@amd.com,
Alexander.Deucher@amd.com, Jinzhou.Su@amd.com,
Shimmer.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] cpufreq: amd_pstate: add AMD pstate EPP support for shared memory type processor
Date: Thu, 15 Sep 2022 11:24:06 -0500 [thread overview]
Message-ID: <a21bdd7d-3ade-4a54-1a7f-42831ce8e83a@amd.com> (raw)
In-Reply-To: <20220909164534.71864-5-Perry.Yuan@amd.com>
On 9/9/22 11:45, Perry Yuan wrote:
> Add Energy Performance Preference support for AMD SOCs which only
> support the shared memory interface that implemented on Zen2 and Zen3
> processors, because this type CPU has no MSR supported, it will use
> ACPI PCC channel to enable EPP and reset desired perf to be zero.
>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
> drivers/cpufreq/amd-pstate.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 451295284a26..fff298744a8e 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -133,12 +133,24 @@ static inline int pstate_enable(bool enable)
>
> static int cppc_enable(bool enable)
> {
> + struct cppc_perf_ctrls perf_ctrls;
> int cpu, ret = 0;
>
> for_each_present_cpu(cpu) {
> ret = cppc_set_enable(cpu, enable);
> if (ret)
> return ret;
> +
> + /* Enable active mode for EPP */
> + ret = cppc_set_auto_epp(cpu, enable);
> + if (ret)
> + return ret;
> +
> + /* Set zero to desired perf to enable EPP control*/
> + perf_ctrls.desired_perf = 0;
> + ret = cppc_set_perf(cpu, &perf_ctrls);
> + if (ret)
> + return ret;
Shouldn't this entire block be indented one additional tab over since its
part of the for_each_present_cpu() loop?
-Nathan
> }
>
> return ret;
next prev parent reply other threads:[~2022-09-15 16:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 16:45 [PATCH 0/7] Implement AMD Pstate EPP Driver Perry Yuan
2022-09-09 16:45 ` [PATCH 1/7] ACPI: CPPC: Add AMD pstate energy performance preference cppc control Perry Yuan
2022-09-09 16:45 ` [PATCH 2/7] cpufreq: amd_pstate: add module parameter to load amd pstate EPP driver Perry Yuan
2022-09-09 18:49 ` Limonciello, Mario
2022-09-13 15:14 ` Yuan, Perry
2022-09-25 16:58 ` Yuan, Perry
2022-09-09 16:45 ` [PATCH 3/7] Documentation: amd-pstate: add EPP profiles introduction Perry Yuan
2022-09-09 16:45 ` [PATCH 4/7] cpufreq: amd_pstate: add AMD pstate EPP support for shared memory type processor Perry Yuan
2022-09-09 18:52 ` Limonciello, Mario
2022-09-13 15:20 ` Yuan, Perry
2022-09-25 17:01 ` Yuan, Perry
2022-09-15 16:24 ` Nathan Fontenot [this message]
2022-09-25 12:23 ` Yuan, Perry
2022-09-29 14:08 ` Nathan Fontenot
2022-09-09 16:45 ` [PATCH 5/7] cpufreq: amd_pstate: add AMD Pstate EPP support for the MSR based processors Perry Yuan
2022-09-15 18:58 ` Nathan Fontenot
2022-09-25 17:12 ` Yuan, Perry
2022-09-09 16:45 ` [PATCH 6/7] cpufreq: amd_pstate: implement amd pstate cpu online and offline callback Perry Yuan
2022-09-09 19:02 ` Limonciello, Mario
2022-09-15 19:03 ` Nathan Fontenot
2022-09-09 16:45 ` [PATCH 7/7] cpufreq: amd-pstate: implement suspend and resume callbacks Perry Yuan
2022-09-09 19:00 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a21bdd7d-3ade-4a54-1a7f-42831ce8e83a@amd.com \
--to=nathan.fontenot@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Shimmer.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).