From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2999369AbdEANc7 (ORCPT ); Mon, 1 May 2017 09:32:59 -0400 Received: from mout.web.de ([212.227.15.14]:50851 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1950734AbdEANcr (ORCPT ); Mon, 1 May 2017 09:32:47 -0400 Subject: [PATCH 1/3] sctp: Replace six seq_printf() calls by seq_putc() From: SF Markus Elfring To: linux-sctp@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Neil Horman , Vlad Yasevich Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Mon, 1 May 2017 15:31:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fqi7Lwp/jgc/5U2GmR8rzVn+fZpcrVp9i5Q4IAxfYVphBoXGgPl RC19MbDVKncXF6jNQAkKndWEth/vdpL7JRBeH7LDIKDuDz4FqbpkrUR535SjOc7k1etOSkX NA4fM+XB1gh05DNCEmc9OuUPIj+u3NSZn9NxoxCLQ2ZhdAemOnwcbxjOjFRQpZkdHzEnMyr /smPkGQgipaoq5efj0s1w== X-UI-Out-Filterresults: notjunk:1;V01:K0:MQWupNMCh3M=:DDYUPsKxT1GReObMnSWFf3 m6WBRCA7FZqV8ObYlC/L6tJ3dr2f38CtD/x73wCVw4/WbAEvB2J1q0g0aiv2n5x6UYphahKTx IPlxQbqyLNv7SPIN1DGFiq0Avbk5cdwsymFZwlZFtOiZFbYlKn5BOaq0Ow5/0Ig8iQ6EmiBhX t1xQBDSsDpmpoqHi9sqVlJN9/qrx63S8ycN4IHiwgqrNGjk26YkZBVBWLmQKdgJtTFAJIjyAC 1milT7etPAJHkf1PedFkphX+ApmW4GS63w5xuiM6r6KDPnAWV+UhUAdcD2gSrVr6QdaZW/v9M VDN5ihj05eEMZw1FcL4qsN8FgrTp/laxRyYKOi2pvtpG38putSF/iDQiz5M0Z+vEMY8BTEq/+ yXDzvtrslWM+LDqJhdz1nGTxuHzvlHQH73YAjeQkUYvH1LdOgjG70zIS040tO226cqn1/DYvU oY4sQxrTQ96S6bB5/2WWebbhJnH0yFmNDLG6L4+h6SzGfKzMhGKimJBZvHqvREpbmQVr6MPiK J3RlfsGpFlm6+0s6sjCntuXzz6J2Qs0eH3NnsIHktOzzwBJjrWgm7qK9vYndYnVy0IAPGfsgQ YMAEwxpwAgKRNNHBCIApz9XDLtS/vloXCbS2Ed9poiLm2H7D+g07n9GNbhq3eZ1VmtdtmUrts /j4QtINUIu0P8jWLycJMXCJzS61ERS8RNod3loIobdVBYnNkCrbbpKfdFsipRDXVGYJuBOYH6 OY1nYKPX+2NmaqMpwHgC89N6V+CSHKtyQ9JVzwrtJY1dbRcjWjuZPCtbc8KBxAhmL/F57O5k1 96NKjbe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 1 May 2017 14:18:52 +0200 Six single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/sctp/proc.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/net/sctp/proc.c b/net/sctp/proc.c index a0b29d43627f..1cf4b6385418 100644 --- a/net/sctp/proc.c +++ b/net/sctp/proc.c @@ -149,9 +149,8 @@ static void sctp_seq_dump_local_addrs(struct seq_file *seq, struct sctp_ep_commo addr = &laddr->a; af = sctp_get_af_specific(addr->sa.sa_family); - if (primary && af->cmp_addr(addr, primary)) { - seq_printf(seq, "*"); - } + if (primary && af->cmp_addr(addr, primary)) + seq_putc(seq, '*'); af->seq_dump_addr(seq, addr); } rcu_read_unlock(); @@ -170,9 +169,8 @@ static void sctp_seq_dump_remote_addrs(struct seq_file *seq, struct sctp_associa addr = &transport->ipaddr; af = sctp_get_af_specific(addr->sa.sa_family); - if (af->cmp_addr(addr, primary)) { - seq_printf(seq, "*"); - } + if (af->cmp_addr(addr, primary)) + seq_putc(seq, '*'); af->seq_dump_addr(seq, addr); } } @@ -232,7 +230,7 @@ static int sctp_eps_seq_show(struct seq_file *seq, void *v) sock_i_ino(sk)); sctp_seq_dump_local_addrs(seq, epb); - seq_printf(seq, "\n"); + seq_putc(seq, '\n'); } read_unlock(&head->lock); local_bh_enable(); @@ -355,5 +353,5 @@ static int sctp_assocs_seq_show(struct seq_file *seq, void *v) sock_i_ino(sk), epb->bind_addr.port, assoc->peer.port); - seq_printf(seq, " "); + seq_putc(seq, ' '); sctp_seq_dump_local_addrs(seq, epb); @@ -369,8 +367,7 @@ static int sctp_assocs_seq_show(struct seq_file *seq, void *v) sk->sk_wmem_queued, sk->sk_sndbuf, sk->sk_rcvbuf); - seq_printf(seq, "\n"); - + seq_putc(seq, '\n'); sctp_transport_put(transport); return 0; @@ -438,7 +435,7 @@ static int sctp_remaddr_seq_show(struct seq_file *seq, void *v) * The remote address (ADDR) */ tsp->af_specific->seq_dump_addr(seq, &tsp->ipaddr); - seq_printf(seq, " "); + seq_putc(seq, ' '); /* * The association ID (ASSOC_ID) */ -- 2.12.2