From: Miaohe Lin <linmiaohe@huawei.com>
To: Suren Baghdasaryan <surenb@google.com>, <sumit.semwal@linaro.org>
Cc: <akpm@linux-foundation.org>, <hch@infradead.org>,
<lmark@codeaurora.org>, <labbott@redhat.com>,
<Brian.Starkey@arm.com>, <john.stultz@linaro.org>,
<christian.koenig@amd.com>, <cgoldswo@codeaurora.org>,
<orjan.eide@arm.com>, <robin.murphy@arm.com>,
<jajones@nvidia.com>, <minchan@kernel.org>, <hridya@google.com>,
<sspatil@google.com>, <linux-media@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<linaro-mm-sig@lists.linaro.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <kernel-team@android.com>
Subject: Re: [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error
Date: Wed, 3 Feb 2021 09:27:04 +0800 [thread overview]
Message-ID: <a2376ae0-c6a2-12e4-d4ad-04696eb51535@huawei.com> (raw)
In-Reply-To: <20210203003134.2422308-1-surenb@google.com>
Hi:
On 2021/2/3 8:31, Suren Baghdasaryan wrote:
> Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with
> WARN_ON_ONCE and returning an error. This is to ensure users of the
> vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage
> and get an indication of an error without panicing the kernel.
> This will help identifying drivers that need to clear VM_PFNMAP before
> using dmabuf system heap which is moving to use vm_insert_page.
>
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Looks reasonable. Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/memory.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index feff48e1465a..e503c9801cd9 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1827,7 +1827,8 @@ int vm_insert_page(struct vm_area_struct *vma, unsigned long addr,
> return -EINVAL;
> if (!(vma->vm_flags & VM_MIXEDMAP)) {
> BUG_ON(mmap_read_trylock(vma->vm_mm));
> - BUG_ON(vma->vm_flags & VM_PFNMAP);
> + if (WARN_ON_ONCE(vma->vm_flags & VM_PFNMAP))
> + return -EINVAL;
> vma->vm_flags |= VM_MIXEDMAP;
> }
> return insert_page(vma, addr, page, vma->vm_page_prot);
>
next prev parent reply other threads:[~2021-02-03 1:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 0:31 [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Suren Baghdasaryan
2021-02-03 0:31 ` [PATCH v2 2/2] dma-buf: heaps: Map system heap pages as managed by linux vm Suren Baghdasaryan
2021-02-03 1:39 ` Minchan Kim
2021-02-03 2:02 ` Suren Baghdasaryan
2021-02-03 8:05 ` Christian König
2021-02-03 19:53 ` Suren Baghdasaryan
2021-02-03 2:07 ` John Stultz
2021-02-03 2:13 ` Suren Baghdasaryan
2021-02-03 1:27 ` Miaohe Lin [this message]
2021-02-03 1:31 ` [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Minchan Kim
2021-02-03 1:55 ` Suren Baghdasaryan
2021-02-03 1:55 ` Matthew Wilcox
2021-02-03 2:26 ` Suren Baghdasaryan
2021-02-03 8:52 ` [Linaro-mm-sig] " Daniel Vetter
2021-02-03 20:20 ` Suren Baghdasaryan
2021-02-03 20:29 ` Daniel Vetter
2021-02-03 21:25 ` Daniel Vetter
2021-02-03 21:41 ` Suren Baghdasaryan
2021-02-04 8:16 ` Christian König
2021-02-04 15:22 ` Daniel Vetter
2021-02-04 15:54 ` Alex Deucher
2021-02-05 3:39 ` Suren Baghdasaryan
2021-02-04 7:53 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2376ae0-c6a2-12e4-d4ad-04696eb51535@huawei.com \
--to=linmiaohe@huawei.com \
--cc=Brian.Starkey@arm.com \
--cc=akpm@linux-foundation.org \
--cc=cgoldswo@codeaurora.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=jajones@nvidia.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lmark@codeaurora.org \
--cc=minchan@kernel.org \
--cc=orjan.eide@arm.com \
--cc=robin.murphy@arm.com \
--cc=sspatil@google.com \
--cc=sumit.semwal@linaro.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).