From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354AbcFOPzP (ORCPT ); Wed, 15 Jun 2016 11:55:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33944 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbcFOPzL (ORCPT ); Wed, 15 Jun 2016 11:55:11 -0400 Subject: Re: [PATCH] mailbox: pcc: Add PCC request and free channel declarations To: Hoan Tran , Ashwin Chaugule , Jassi Brar , "Rafael J. Wysocki" , Len Brown References: <1465945963-22353-1-git-send-email-hotran@apm.com> Cc: Robert Moore , Lv Zheng , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, devel@acpica.org, lho@apm.com, Duc Dang From: "Prakash, Prashanth" Message-ID: Date: Wed, 15 Jun 2016 09:55:06 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465945963-22353-1-git-send-email-hotran@apm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hoan, On 6/14/2016 5:12 PM, Hoan Tran wrote: > As PCC will be used by other clients not only CPPC. > This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() > declarations > > Signed-off-by: Hoan Tran > --- > include/acpi/cppc_acpi.h | 4 ---- > include/linux/mailbox_client.h | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h > index dad8af3..819b4b9 100644 > --- a/include/acpi/cppc_acpi.h > +++ b/include/acpi/cppc_acpi.h > @@ -130,8 +130,4 @@ extern int cppc_set_perf(int cpu, struct cppc_perf_ctrls *perf_ctrls); > extern int cppc_get_perf_caps(int cpu, struct cppc_perf_caps *caps); > extern int acpi_get_psd_map(struct cpudata **); > > -/* Methods to interact with the PCC mailbox controller. */ > -extern struct mbox_chan * > - pcc_mbox_request_channel(struct mbox_client *, unsigned int); > - > #endif /* _CPPC_ACPI_H*/ > diff --git a/include/linux/mailbox_client.h b/include/linux/mailbox_client.h > index 41e2af8..2758d18 100644 > --- a/include/linux/mailbox_client.h > +++ b/include/linux/mailbox_client.h > @@ -50,4 +50,8 @@ void mbox_client_txdone(struct mbox_chan *chan, int r); /* atomic */ > bool mbox_client_peek_data(struct mbox_chan *chan); /* atomic */ > void mbox_free_channel(struct mbox_chan *chan); /* may sleep */ > > +/* Methods to interact with the PCC mailbox controller. */ > +struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *, int); > +void pcc_mbox_free_channel(struct mbox_chan *chan); > + Since these APIs are specific to PCC, may be we should introduce a new header for pcc clients instead of adding to the common mailbox_client header. > #endif /* __MAILBOX_CLIENT_H */ Thanks, Prashanth