From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371ECC433FE for ; Mon, 11 Apr 2022 00:55:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239418AbiDKA5g (ORCPT ); Sun, 10 Apr 2022 20:57:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237820AbiDKA5f (ORCPT ); Sun, 10 Apr 2022 20:57:35 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1537115FC4 for ; Sun, 10 Apr 2022 17:55:23 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id u19so8637323ljd.11 for ; Sun, 10 Apr 2022 17:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=OGafDg3DxeHztujL+sSHxizX/gbRwwn9uMxQuC04w7k=; b=hsIdT/GmWbO+U9EX4aKGvbGV8JS8jvtcjwggO/EJFEm3VcYSmGVdL5lYZOa1rJgiL/ plK7KaELvjRgYwi4v/WIkiB0eHJXUIdk5L67hRcklZuAhhTYuZQf6POsJg7/K+sKKEb0 5SAttD+FHIJwJXpLYsOKDKEzPhQli9WIBnCPnpWd9zcJnxThatcsy15uXc35UMqsCbJ3 CIXXREMdLa8l/EYJDbqTKgelf3GSUkXTBfVPYnTeJsjJnPsCaTe0+Au5CaARYjsOAYfj MX7o8hNSx31P0f9j0a6SRlsjbmToThwVzNkR5lkBN+R2SPqTtNVD7aNaPupdK2llJKjJ 8CPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OGafDg3DxeHztujL+sSHxizX/gbRwwn9uMxQuC04w7k=; b=2jrzQhS+fz//5FUFGwOPEZjwCtssBDFI7YMTCGnOBudiUbvVN1n5vAWuDEcq44IUkW TuQwdqd1iRPNtGvRXfW5dYrn6DOgb/Z3KRyQq2w58tZiL1PqX9Ou3lSUCoDDcVqUNdxq bFGYqZJZMvUYIgrgZt55q4mdY9anFX8Sk1hX78t55XcLLbAXnITrDC9aNcJejocPlZ85 D7vsmjeh381jHedKIUCzmd8tQ6YfT1WnDfhd9goEX3fpm/i49ITUl2Mo5+r933MEEyDU 0/gRTb/FeorT88Bjn9P8ynDg9PJkKc8zL4fDa6QHCIjgLDRwBMnXcaGtHa2yOickj65H aZpw== X-Gm-Message-State: AOAM532pJXfWEyddFd3UEYxZo8Z2Rtcnhv80Nvp9/vTvDObhyuefcERX lVpuhjjQkYQG86JwlN3adurRRg== X-Google-Smtp-Source: ABdhPJyO8+aniDjnYx0zU3hsNKlVq026qfQlqZSsrhX6p6/U0Zl56YhNUcNT+MVRGEnOdhKodQiglg== X-Received: by 2002:a05:651c:548:b0:24b:5e49:7714 with SMTP id q8-20020a05651c054800b0024b5e497714mr3939851ljp.223.1649638521243; Sun, 10 Apr 2022 17:55:21 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id g15-20020a056512118f00b0044a835fd17esm3161424lfr.162.2022.04.10.17.55.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Apr 2022 17:55:20 -0700 (PDT) Message-ID: Date: Mon, 11 Apr 2022 03:55:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] drm/msm/dsi: Use connector directly in msm_dsi_manager_connector_init() Content-Language: en-GB To: Stephen Boyd , Rob Clark , Sean Paul Cc: linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Sean Paul References: <20220318000731.2823718-1-swboyd@chromium.org> From: Dmitry Baryshkov In-Reply-To: <20220318000731.2823718-1-swboyd@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/03/2022 03:07, Stephen Boyd wrote: > The member 'msm_dsi->connector' isn't assigned until > msm_dsi_manager_connector_init() returns (see msm_dsi_modeset_init() and > how it assigns the return value). Therefore this pointer is going to be > NULL here. Let's use 'connector' which is what was intended. > > Cc: Dmitry Baryshkov > Cc: Sean Paul > Fixes: 6d5e78406991 ("drm/msm/dsi: Move dsi panel init into modeset init path") > Signed-off-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry