From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647DAC433E0 for ; Wed, 3 Feb 2021 09:58:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05A6764F67 for ; Wed, 3 Feb 2021 09:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233724AbhBCJ6L (ORCPT ); Wed, 3 Feb 2021 04:58:11 -0500 Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]:51955 "EHLO lb3-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233634AbhBCJ5l (ORCPT ); Wed, 3 Feb 2021 04:57:41 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud7.xs4all.net with ESMTPA id 7Eu4l7qd0efbk7Eu8lmOu2; Wed, 03 Feb 2021 10:56:57 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1612346217; bh=U1Sp35ageTIQ7Z24/ieyKMmHRgJqKCgycRLXITO4oTs=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=flgIL/8vIL57Z4ADScZH/J6Z21tMcFqgSg+UgkRgL0ErQSr4gpn9no6Y4BBYkXElO NXmo1YR2TQIR1IQCOS7sprJvWB0AWod5fTDlX8D0H/7+2+Z9F9QO8XuiJ7pefw1/yW /sn7j4sWUfw17n9OdDZX+aD9tkt7Aita7ysIh6+rENcUzeQUEuyO0ptHgRpIx8hljx HefIeVg6NfbQKdP+bs3lEt9m3NNWDbGvV/do/xbMjhoOBz6NH7XF8Eh+UAQYUXvRwc sd1qqyjGJPvDxyoJcuI0mJCYb4AzVqTI3YiU/dsHgUwJ5sFdW3kY2kmroGbZ3T8vWo n/so+LPytcT0Q== Subject: Re: [PATCH v3 1/4] dp/dp_mst: Add support for sink event notify messages To: Sam McNally , LKML Cc: Thomas Zimmermann , David Airlie , dri-devel@lists.freedesktop.org, lyude@redhat.com References: <20200923121320.v3.1.I8693156f555875e5c8342e86ab37ce968dfdd277@changeid> <57384ff32e3b42e8ea72ca298e9ae1f7fdac25d7.camel@redhat.com> From: Hans Verkuil Message-ID: Date: Wed, 3 Feb 2021 10:56:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <57384ff32e3b42e8ea72ca298e9ae1f7fdac25d7.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfONWT7YltPpdomjmt2oGohE0dlyMqevsghxzfNpix34sc7AtQOx3yEsPjK3X+KY+P8rTe6imITGzKgWeoB9udv1QqvPE8I38q5CMHSPmcHKSoUcU2aWP b5I9sV2TeeUGn2iRDitUnN+Yy/tl7wi6t1uRUoTgxdV5IX3sDYZe6NlaikZmQu++imkRqwuM96565adiXR5XoibPV3TlMFLJaEqXfJ9JtzFPQvoSFhvfHIjq irqrgJ1F7k/HGpDOSBm8vIAyuJ3O9iMmZw5EwOBsBKem0NKC8SzH2+f9fMQgXe5fiwUGRnrnvsu4cwtg3pF6zzwct1E9+i3W2roLpTpxamXmv/Jra+ubuowk EOCqCwyS Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, Are you able to work on a v4? I haven't heard from you for some time now. I would be willing to take over this series if it wasn't for the fact that I do not have any hardware to test this with. Regards, Hans On 01/02/2021 22:56, Lyude Paul wrote: > On Wed, 2020-09-23 at 12:13 +1000, Sam McNally wrote: >> Sink event notify messages are used for MST CEC IRQs. Add parsing >> support for sink event notify messages in preparation for handling MST >> CEC IRQs. >> >> Signed-off-by: Sam McNally >> --- >> >> (no changes since v1) >> >>  drivers/gpu/drm/drm_dp_mst_topology.c | 37 ++++++++++++++++++++++++++- >>  include/drm/drm_dp_mst_helper.h       | 14 ++++++++++ >>  2 files changed, 50 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c >> b/drivers/gpu/drm/drm_dp_mst_topology.c >> index 17dbed0a9800..15b6cc39a754 100644 >> --- a/drivers/gpu/drm/drm_dp_mst_topology.c >> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c >> @@ -1027,6 +1027,30 @@ static bool >> drm_dp_sideband_parse_resource_status_notify(struct drm_dp_sideband_ >>         return false; >>  } >>   >> +static bool drm_dp_sideband_parse_sink_event_notify( >> +       struct drm_dp_sideband_msg_rx *raw, >> +       struct drm_dp_sideband_msg_req_body *msg) >> +{ >> +       int idx = 1; >> + >> +       msg->u.sink_event.port_number = (raw->msg[idx] & 0xf0) >> 4; >> +       idx++; >> +       if (idx > raw->curlen) >> +               goto fail_len; >> + >> +       memcpy(msg->u.sink_event.guid, &raw->msg[idx], 16); >> +       idx += 16; >> +       if (idx > raw->curlen) >> +               goto fail_len; >> + >> +       msg->u.sink_event.event_id = (raw->msg[idx] << 8) | (raw->msg[idx + >> 1]); >> +       idx++; >> +       return true; >> +fail_len: >> +       DRM_DEBUG_KMS("sink event notify parse length fail %d %d\n", idx, raw- >>> curlen); > > Is it possible for us to use drm_dbg_kms() here? > > Also-there is an MST selftest you should update for this > >> +       return false; >> +} >> + >>  static bool drm_dp_sideband_parse_req(struct drm_dp_sideband_msg_rx *raw, >>                                       struct drm_dp_sideband_msg_req_body >> *msg) >>  { >> @@ -1038,6 +1062,8 @@ static bool drm_dp_sideband_parse_req(struct >> drm_dp_sideband_msg_rx *raw, >>                 return drm_dp_sideband_parse_connection_status_notify(raw, >> msg); >>         case DP_RESOURCE_STATUS_NOTIFY: >>                 return drm_dp_sideband_parse_resource_status_notify(raw, msg); >> +       case DP_SINK_EVENT_NOTIFY: >> +               return drm_dp_sideband_parse_sink_event_notify(raw, msg); >>         default: >>                 DRM_ERROR("Got unknown request 0x%02x (%s)\n", msg->req_type, >>                           drm_dp_mst_req_type_str(msg->req_type)); >> @@ -3875,6 +3901,8 @@ drm_dp_mst_process_up_req(struct drm_dp_mst_topology_mgr >> *mgr, >>                         guid = msg->u.conn_stat.guid; >>                 else if (msg->req_type == DP_RESOURCE_STATUS_NOTIFY) >>                         guid = msg->u.resource_stat.guid; >> +               else if (msg->req_type == DP_SINK_EVENT_NOTIFY) >> +                       guid = msg->u.sink_event.guid; >>   >>                 if (guid) >>                         mstb = drm_dp_get_mst_branch_device_by_guid(mgr, >> guid); >> @@ -3948,7 +3976,8 @@ static int drm_dp_mst_handle_up_req(struct >> drm_dp_mst_topology_mgr *mgr) >>         drm_dp_sideband_parse_req(&mgr->up_req_recv, &up_req->msg); >>   >>         if (up_req->msg.req_type != DP_CONNECTION_STATUS_NOTIFY && >> -           up_req->msg.req_type != DP_RESOURCE_STATUS_NOTIFY) { >> +           up_req->msg.req_type != DP_RESOURCE_STATUS_NOTIFY && >> +           up_req->msg.req_type != DP_SINK_EVENT_NOTIFY) { >>                 DRM_DEBUG_KMS("Received unknown up req type, ignoring: %x\n", >>                               up_req->msg.req_type); >>                 kfree(up_req); >> @@ -3976,6 +4005,12 @@ static int drm_dp_mst_handle_up_req(struct >> drm_dp_mst_topology_mgr *mgr) >>                 DRM_DEBUG_KMS("Got RSN: pn: %d avail_pbn %d\n", >>                               res_stat->port_number, >>                               res_stat->available_pbn); >> +       } else if (up_req->msg.req_type == DP_SINK_EVENT_NOTIFY) { >> +               const struct drm_dp_sink_event_notify *sink_event = >> +                       &up_req->msg.u.sink_event; >> + >> +               DRM_DEBUG_KMS("Got SEN: pn: %d event_id %d\n", >> +                             sink_event->port_number, sink_event->event_id); >>         } >>   >>         up_req->hdr = mgr->up_req_recv.initial_hdr; >> diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h >> index 6ae5860d8644..c7c79e0ced18 100644 >> --- a/include/drm/drm_dp_mst_helper.h >> +++ b/include/drm/drm_dp_mst_helper.h >> @@ -402,6 +402,19 @@ struct drm_dp_resource_status_notify { >>         u16 available_pbn; >>  }; >>   >> +#define DP_SINK_EVENT_PANEL_REPLAY_ACTIVE_FRAME_CRC_ERROR      BIT(0) >> +#define DP_SINK_EVENT_PANEL_REPLAY_RFB_STORAGE_ERROR           BIT(1) >> +#define DP_SINK_EVENT_DSC_RC_BUFFER_UNDER_RUN                  BIT(2) >> +#define DP_SINK_EVENT_DSC_RC_BUFFER_OVERFLOW                   BIT(3) >> +#define DP_SINK_EVENT_DSC_CHUNK_LENGTH_ERROR                   BIT(4) >> +#define DP_SINK_EVENT_CEC_IRQ_EVENT                            BIT(5) >> + >> +struct drm_dp_sink_event_notify { >> +       u8 port_number; >> +       u8 guid[16]; >> +       u16 event_id; >> +}; >> + >>  struct drm_dp_query_payload_ack_reply { >>         u8 port_number; >>         u16 allocated_pbn; >> @@ -413,6 +426,7 @@ struct drm_dp_sideband_msg_req_body { >>                 struct drm_dp_connection_status_notify conn_stat; >>                 struct drm_dp_port_number_req port_num; >>                 struct drm_dp_resource_status_notify resource_stat; >> +               struct drm_dp_sink_event_notify sink_event; >>   >>                 struct drm_dp_query_payload query_payload; >>                 struct drm_dp_allocate_payload allocate_payload; >