From: boris.ostrovsky@oracle.com
To: Dan Williams <dan.j.williams@intel.com>, akpm@linux-foundation.org
Cc: "Paul Mackerras" <paulus@ozlabs.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Vishal Verma" <vishal.l.verma@intel.com>,
"Vivek Goyal" <vgoyal@redhat.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Ira Weiny" <ira.weiny@intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
dave.hansen@linux.intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
david@redhat.com, joao.m.martins@oracle.com
Subject: Re: [PATCH v6 09/11] mm/memremap_pages: convert to 'struct range'
Date: Thu, 8 Oct 2020 15:52:14 -0400 [thread overview]
Message-ID: <a2a740e2-424c-69ff-45a6-3d71feac5c50@oracle.com> (raw)
In-Reply-To: <160196733645.2166475.12840692906594512941.stgit@dwillia2-desk3.amr.corp.intel.com>
On 10/6/20 2:55 AM, Dan Williams wrote:
> The 'struct resource' in 'struct dev_pagemap' is only used for holding
> resource span information. The other fields, 'name', 'flags', 'desc',
> 'parent', 'sibling', and 'child' are all unused wasted space.
>
> This is in preparation for introducing a multi-range extension of
> devm_memremap_pages().
>
> The bulk of this change is unwinding all the places internal to libnvdimm
> that used 'struct resource' unnecessarily, and replacing instances of
> 'struct dev_pagemap'.res with 'struct dev_pagemap'.range.
>
> P2PDMA had a minor usage of the resource flags field, but only to report
> failures with "%pR". That is replaced with an open coded print of the
> range.
>
> Link: https://lkml.kernel.org/r/159643103173.4062302.768998885691711532.stgit@dwillia2-desk3.amr.corp.intel.com
> Link: https://lkml.kernel.org/r/20200926121402.GA7467@kadam
> Cc: Paul Mackerras <paulus@ozlabs.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Vivek Goyal <vgoyal@redhat.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Ira Weiny <ira.weiny@intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: "Jérôme Glisse" <jglisse@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
For Xen bits
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
next prev parent reply other threads:[~2020-10-08 19:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 6:54 [PATCH v6 00/11] device-dax: support sub-dividing soft-reserved ranges Dan Williams
2020-10-06 6:54 ` [PATCH v6 01/11] device-dax: make pgmap optional for instance creation Dan Williams
2020-10-06 6:54 ` [PATCH v6 02/11] device-dax/kmem: introduce dax_kmem_range() Dan Williams
2020-10-06 6:55 ` [PATCH v6 03/11] device-dax/kmem: move resource tracking to drvdata Dan Williams
2020-10-06 8:14 ` David Hildenbrand
2020-10-06 6:55 ` [PATCH v6 04/11] device-dax: add an allocation interface for device-dax instances Dan Williams
2020-10-06 6:55 ` [PATCH v6 05/11] device-dax: introduce 'struct dev_dax' typed-driver operations Dan Williams
2020-10-06 6:55 ` [PATCH v6 06/11] device-dax: introduce 'seed' devices Dan Williams
2020-10-06 6:55 ` [PATCH v6 07/11] drivers/base: make device_find_child_by_name() compatible with sysfs inputs Dan Williams
2020-10-06 6:55 ` [PATCH v6 08/11] device-dax: add resize support Dan Williams
2020-10-06 6:55 ` [PATCH v6 09/11] mm/memremap_pages: convert to 'struct range' Dan Williams
2020-10-08 19:52 ` boris.ostrovsky [this message]
2020-10-06 6:55 ` [PATCH v6 10/11] mm/memremap_pages: support multiple ranges per invocation Dan Williams
2020-10-06 6:55 ` [PATCH v6 11/11] device-dax: add dis-contiguous resource support Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2a740e2-424c-69ff-45a6-3d71feac5c50@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bskeggs@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=ira.weiny@intel.com \
--cc=jglisse@redhat.com \
--cc=jgross@suse.com \
--cc=joao.m.martins@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=sstabellini@kernel.org \
--cc=vgoyal@redhat.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).