From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A880C433DB for ; Tue, 26 Jan 2021 15:50:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50E552083E for ; Tue, 26 Jan 2021 15:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391670AbhAZPuJ (ORCPT ); Tue, 26 Jan 2021 10:50:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392714AbhAZPsj (ORCPT ); Tue, 26 Jan 2021 10:48:39 -0500 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91158C061D73 for ; Tue, 26 Jan 2021 07:47:57 -0800 (PST) Received: by mail-pg1-x52b.google.com with SMTP id r38so5772189pgk.13 for ; Tue, 26 Jan 2021 07:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1x9LcmflL/RTdretuBZJnXxKrfKid3zNWQywy21TUpc=; b=qaKSUwQtZ2h/z3VY8p3dor+qBdjQvTF50BJYaN/IFpwDvVfRwsY/7gKmpff4psZmDo EIAhDAhUxcEfgckDZ9YnAG+HuWDSEtDTVW2qbbaL13bV51sjtzdGAy2JkvrRsRyDahvh 0GfK3PvWWYyISL/+FRHmaOfqUBy1nx4KiXuUEmVoJrY9aVc+qV/d18ZTwySSbuv41lo+ xv66T++ko3TmO8LQPyeEzLUNwpClh+6vSjA6QurcUKj1KCIZUVvXK5iquJJK9AdmkF0p 5neCeQ4iU0plRWfdr5N1/rq+iMWOVrKMfjQn3bzBVoz7mQqbYP65jfW+PoPvhl1H+lmk ArGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1x9LcmflL/RTdretuBZJnXxKrfKid3zNWQywy21TUpc=; b=KYOEWA+OOGBeBBJUMhBdgbBfN0urcZI68c/1BHCcrNbVfhmwh7JeyUu0QqReOF+A1b VVkY5QgogEMFL0qHGKEGPFNR8kQT/RHazQXcLCV/lkJTUPpbmWjzB1S2j/nJMzGY8+U5 FjMv01M05kjjxPC5X0t8nSVUd5/ANwzLScS5mr0wpn+p8Ta8UnjkJADFRjlPE9IFPLEJ 9GPBw0PjD/yamcS1zhrESg1UQEzWAp4+nOmG17bOunQ4+/e5NLLVfrSjRAVl7+HdWU7e o11k19TOuKVLpvzWhYGaE6yykr7v9ztCnmVqlkeEAee2yJwlY24rXQA/zqvvHLt6MZmD J22A== X-Gm-Message-State: AOAM532Ri2IgSyuslF90YiWibMi0V/JlGSujmAbbsvfZMJuNKaUri94l vsuNCNcfhyoj0Pjv9IBKcSuYpw== X-Google-Smtp-Source: ABdhPJzpVv6puQt3HY7WsP4woZzvAy3kkO5fdI8te5lGrQBAdCBMyyIzLbeEnD9ZmYABOohmWggLcA== X-Received: by 2002:a63:450d:: with SMTP id s13mr6063176pga.443.1611676077130; Tue, 26 Jan 2021 07:47:57 -0800 (PST) Received: from [192.168.4.41] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id fv12sm2610575pjb.22.2021.01.26.07.47.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jan 2021 07:47:56 -0800 (PST) Subject: Re: linux-next: Fixes tag needs some work in the block tree To: Jan Kara Cc: Paolo Valente , Stephen Rothwell , Jia Cheng Hu , Linux Kernel Mailing List , Linux Next Mailing List References: <20210125204032.6b6a604b@canb.auug.org.au> <3F91181A-EDF2-4F01-9839-17B40D6EA07F@linaro.org> <20210126132946.GC10966@quack2.suse.cz> From: Jens Axboe Message-ID: Date: Tue, 26 Jan 2021 08:47:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210126132946.GC10966@quack2.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/26/21 6:29 AM, Jan Kara wrote: > On Mon 25-01-21 11:39:50, Jens Axboe wrote: >> On 1/25/21 11:35 AM, Paolo Valente wrote: >>> >>> >>>> Il giorno 25 gen 2021, alle ore 10:40, Stephen Rothwell ha scritto: >>>> >>>> Hi all, >>>> >>>> In commit >>>> >>>> d4fc3640ff36 ("block, bfq: set next_rq to waker_bfqq->next_rq in waker injection") >>>> >>>> Fixes tag >>>> >>>> Fixes: c5089591c3ba ("block, bfq: detect wakers and unconditionally inject their I/O") >>>> >>>> has these problem(s): >>>> >>>> - Target SHA1 does not exist >>>> >>>> Maybe you meant >>>> >>>> Fixes: 13a857a4c4e8 ("block, bfq: detect wakers and unconditionally inject their I/O") >>>> >>> >>> Hi Jens, >>> how to proceed in such a case (with patches already applied by you)? >>> Shall I send you a v2 with only this change? >> >> We just have to ignore it... But in the future, always double check that >> you are using the right shas, not some sha from an internal tree. > > FWIW I have a commit hook in my git tree that just refuses a commit with > unknown Fixes tag SHA. Exactly to catch such mishaps in the patches I > merge... That's not a bad idea, would help catch it upfront. Can you share the hook? -- Jens Axboe