From: Guenter Roeck <linux@roeck-us.net>
To: Camel Guo <camel.guo@axis.com>, Jean Delvare <jdelvare@suse.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@axis.com
Subject: Re: [PATCH v2] hwmon: (tmp401) Add of_match_table
Date: Mon, 2 May 2022 06:57:50 -0700 [thread overview]
Message-ID: <a2e81680-e62c-dddd-ee58-6f5aa3664d2f@roeck-us.net> (raw)
In-Reply-To: <20220502091942.1083067-1-camel.guo@axis.com>
On 5/2/22 02:19, Camel Guo wrote:
> When tmp401 is built as kernel module, it won't be automatically loaded
> even through there is a device node in the devicetree. e.g:
> i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
> sensor@4c {
> compatible = "ti,tmp401";
> reg = <0x4c>;
> };
> };
> In order to make sure it is loaded automatically, this commit adds
> of_match_table for tmp401.
>
As mentioned before, historically i2c devices would instantiate based
on the i2c match table. You are claiming that this is no longer the case.
The above is no evidence; that would require a log output on an affected
system showing that the sensors are not or no longer longer instantiated.
I am not absolutely opposed to adding the nodes, but the explanation
needs to match reality. If you can not provide evidence from an actual
boot log, I'll have to implement a tmp401 device model in qemu and test
myself. That will take a while.
Guenter
next prev parent reply other threads:[~2022-05-02 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 9:19 [PATCH v2] hwmon: (tmp401) Add of_match_table Camel Guo
2022-05-02 13:57 ` Guenter Roeck [this message]
2022-05-02 14:58 ` Vincent Whitchurch
2022-05-02 16:16 ` Guenter Roeck
2022-05-03 5:35 ` Camel Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2e81680-e62c-dddd-ee58-6f5aa3664d2f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=camel.guo@axis.com \
--cc=jdelvare@suse.com \
--cc=kernel@axis.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).