From: Zhang Rui <rui.zhang@intel.com>
To: LKML <linux-kernel@vger.kernel.org>, x86@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, "H. Peter Anvin" <hpa@zytor.com>,
Len Brown <len.brown@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 0/7] x86/topology: Improve CPUID.1F handling
Date: Fri, 12 Aug 2022 23:12:02 +0800 [thread overview]
Message-ID: <a2fc8901e4fab5bde5e0ac3f4973e68b1fa83a0e.camel@intel.com> (raw)
In-Reply-To: <41fc865a1e207ea03e15067c06856a92c58e18f6.camel@intel.com>
Resend with x86 mailing list.
On Fri, 2022-08-12 at 23:08 +0800, Zhang Rui wrote:
> On Intel AlderLake-N platforms where there are Ecores only, the Ecore
> Module topology is enumerated via CPUID.1F Module level, which has
> not
> been supported by Linux kernel yet.
>
> This exposes two issues in current CPUID.1F handling code.
> 1. Linux interprets the Module id bits as package id and erroneously
> reports a multi module system as a multi-package system.
> 2. Linux excludes the unknown Module id bits from the core_id, and
> results in duplicate core_id’s shown in a package after the first
> issue
> solved.
>
> Plus that, a third problem is observed on Intel Hybrid ADL-S/P
> platforms. The return value of CPUID.1F SMT level EBX (number of
> siblings) differs on Pcore CPUs and Ecore CPUs, and results in
> inconsistent smp_num_siblings value based on the Pcore/Ecore CPU
> enumeration order.
>
> Patch 1/7 and 2/7 fix the first two issues. And at the same time, it
> reveals a reality that the core_id could be sparse on platforms with
> CPUID.1F support.
> Patch 3/7 improves coretemp driver code to be able to handle sparse
> and
> large core id, which is the only driver that uses core_id as array
> index and run on platforms with CPUID.1F support.
>
> Patch 4/7 to 7/7 propose a fix for the third problem and update the
> related Documents.
>
> The patch series have been tested on Intel ICL/CLX servers,
> SKL/KBL/ADL
> clients.
>
> thanks,
> -rui
next prev parent reply other threads:[~2022-08-12 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 15:08 [PATCH 0/7] x86/topology: Improve CPUID.1F handling Zhang Rui
2022-08-12 15:12 ` Zhang Rui [this message]
2022-08-12 16:09 ` Guenter Roeck
2022-08-12 16:13 ` Zhang Rui
2022-08-12 16:41 Zhang Rui
2022-08-13 10:44 ` Ingo Molnar
2022-08-13 17:10 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2fc8901e4fab5bde5e0ac3f4973e68b1fa83a0e.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).