From: Peter Rosin <peda@axentia.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jonathan Corbet <corbet@lwn.net>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2 2/3] fbdev: fbmem: allow overriding the number of bootup logos
Date: Tue, 27 Aug 2019 08:54:06 +0000 [thread overview]
Message-ID: <a31ff144-f037-3580-08b5-aa368572c69d@axentia.se> (raw)
In-Reply-To: <CAMuHMdVx77aOyUVhZ2_N76VAP+AJ3X8w-gdHLjnjUEeRKcZmOA@mail.gmail.com>
On 2019-08-27 10:36, Geert Uytterhoeven wrote:
> Hi Peter,
>
> On Mon, Aug 26, 2019 at 10:46 PM Peter Rosin <peda@axentia.se> wrote:
>> Probably most useful if you only want one logo regardless of how many
>> CPU cores you have.
>>
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>
> Thanks for your patch!
>
>> --- a/Documentation/fb/fbcon.rst
>> +++ b/Documentation/fb/fbcon.rst
>> @@ -174,6 +174,11 @@ C. Boot options
>> displayed due to multiple CPUs, the collected line of logos is moved
>> as a whole.
>>
>> +9. fbcon=logo-count:<n>
>> +
>> + The value 'n' overrides the number of bootup logos. Zero gives the
>> + default, which is the number of online cpus.
>
> Isn't that a bit unexpected for the user?
> What about making -1 the default (auto), and zero meaning no logos?
I just naively assumed there was some other mechanism to disable it.
Sigh, I'll take a look. v3 coming up...
Cheers,
Peter
next prev parent reply other threads:[~2019-08-27 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 19:58 [PATCH v2 0/3] Add possibility to specify the number of displayed logos Peter Rosin
2019-08-26 19:58 ` [PATCH v2 1/3] fbdev: fix numbering of fbcon options Peter Rosin
2019-08-26 19:58 ` [PATCH v2 2/3] fbdev: fbmem: allow overriding the number of bootup logos Peter Rosin
2019-08-27 8:36 ` Geert Uytterhoeven
2019-08-27 8:54 ` Peter Rosin [this message]
2019-08-27 9:18 ` Geert Uytterhoeven
2019-08-26 19:59 ` [PATCH v2 3/3] fbdev: fbmem: avoid exporting fb_center_logo Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a31ff144-f037-3580-08b5-aa368572c69d@axentia.se \
--to=peda@axentia.se \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).