Re: [RFC PATCH 0/3] x86/paravirt: Get rid of paravirt patching

From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Srivatsa S. Bhat (VMware)" <srivatsa@csail.mit.edu>,
	Alexey Makhalov <amakhalov@vmware.com>,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [RFC PATCH 0/3] x86/paravirt: Get rid of paravirt patching
Date: Thu, 24 Aug 2023 11:01:56 +0200	[thread overview]
Message-ID: <a32e211f-4add-4fb2-9e5a-480ae9b9bbf2@suse.com> (raw)
In-Reply-To: <acda7276-234b-9036-c178-ca2b441f3998@suse.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 2237 bytes --]

PING!

On 10.07.23 14:29, Juergen Gross wrote:
> Any comments?
> 
> On 08.06.23 16:03, Juergen Gross wrote:
>> This is a small series getting rid of paravirt patching by switching
>> completely to alternative patching for the same functionality.
>>
>> The basic idea is to add the capability to switch from indirect to
>> direct calls via a special alternative patching option.
>>
>> This removes _some_ of the paravirt macro maze, but most of it needs
>> to stay due to the need of hiding the call instructions from the
>> compiler in order to avoid needless register save/restore.
>>
>> What is going away is the nasty stacking of alternative and paravirt
>> patching and (of course) the special .parainstructions linker section.
>>
>> I have tested the series on bare metal and as Xen PV domain to still
>> work.
>>
>> RFC because I'm quite sure there will be some objtool work needed
>> (at least removing the specific paravirt handling).
>>
>> Juergen Gross (3):
>>    x86/paravirt: move some functions and defines to alternative
>>    x86/alternative: add indirect call patching
>>    x86/paravirt: switch mixed paravirt/alternative calls to alternative_2
>>
>>   arch/x86/include/asm/alternative.h        | 26 +++++-
>>   arch/x86/include/asm/paravirt.h           | 39 ++-------
>>   arch/x86/include/asm/paravirt_types.h     | 68 +++-------------
>>   arch/x86/include/asm/qspinlock_paravirt.h |  4 +-
>>   arch/x86/include/asm/text-patching.h      | 12 ---
>>   arch/x86/kernel/alternative.c             | 99 +++++++++++------------
>>   arch/x86/kernel/callthunks.c              | 17 ++--
>>   arch/x86/kernel/kvm.c                     |  4 +-
>>   arch/x86/kernel/module.c                  | 20 ++---
>>   arch/x86/kernel/paravirt.c                | 54 ++-----------
>>   arch/x86/kernel/vmlinux.lds.S             | 13 ---
>>   arch/x86/tools/relocs.c                   |  2 +-
>>   arch/x86/xen/irq.c                        |  2 +-
>>   13 files changed, 111 insertions(+), 249 deletions(-)
>>
> 

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]