From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Phil Auld <pauld@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Kate Carcia <kcarcia@redhat.com>,
Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alexandre Chartre <alexandre.chartre@oracle.com>,
Clark Willaims <williams@redhat.com>,
John Kacur <jkacur@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH V3 7/9] tracing: Add __print_ns_to_secs() and __print_ns_without_secs() helpers
Date: Fri, 4 Jun 2021 18:07:18 +0200 [thread overview]
Message-ID: <a343ad15-4deb-ae14-eead-60f7d95fa7d3@redhat.com> (raw)
In-Reply-To: <20210603172902.41648183@gandalf.local.home>
On 6/3/21 11:29 PM, Steven Rostedt wrote:
> On Fri, 14 May 2021 22:51:16 +0200
> Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
>
>> +++ b/include/trace/trace_events.h
>> @@ -358,6 +358,21 @@ TRACE_MAKE_SYSTEM_STR();
>> trace_print_hex_dump_seq(p, prefix_str, prefix_type, \
>> rowsize, groupsize, buf, len, ascii)
>>
>> +#undef __print_ns_to_secs
>> +#define __print_ns_to_secs(value) \
>> + ({ \
>> + u64 ____val = (u64)value; \
>> + do_div(____val, NSEC_PER_SEC); \
>> + ____val; \
>> + })
>
> I know my name is on this, but we need parenthesis around "value".
>
>> +
>> +#undef __print_ns_without_secs
>> +#define __print_ns_without_secs(value) \
>> + ({ \
>> + u64 ____val = (u64)value; \
>
> Here too.
>
>> + (u32) do_div(____val, NSEC_PER_SEC); \
>> + })
>> +
>> #undef DECLARE_EVENT_CLASS
>> #define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print) \
>> static notrace enum print_line_t \
>> @@ -736,6 +751,16 @@ static inline void ftrace_test_probe_##call(void) \
>> #undef __print_array
>> #undef __print_hex_dump
>>
>> +/*
>> + * The below is not executed in the kernel. It is only what is
>> + * displayed in the print format for userspace to parse.
>> + */
>> +#undef __print_ns_to_secs
>> +#define __print_ns_to_secs(val) val / 1000000000UL
>> +
>> +#undef __print_ns_without_secs
>> +#define __print_ns_without_secs(val) val % 1000000000UL
>
> And around "val" in the above two macros.
Fixing in the v4.
Thanks Steven!
-- Daniel
> -- Steve
>
>> +
>> #undef TP_printk
>> #define TP_printk(fmt, args...) "\"" fmt "\", " __stringify(args)
>>
>
next prev parent reply other threads:[~2021-06-04 16:09 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 20:51 [PATCH V3 0/9] hwlat improvements and osnoise/timerlat tracers Daniel Bristot de Oliveira
2021-05-14 20:51 ` [PATCH V3 1/9] tracing/hwlat: Fix Clark's email Daniel Bristot de Oliveira
2021-05-14 20:51 ` [PATCH V3 2/9] tracing/hwlat: Implement the mode config option Daniel Bristot de Oliveira
2021-06-03 20:11 ` Steven Rostedt
2021-05-14 20:51 ` [PATCH V3 3/9] tracing/hwlat: Switch disable_migrate to mode none Daniel Bristot de Oliveira
2021-05-14 20:51 ` [PATCH V3 4/9] tracing/hwlat: Implement the per-cpu mode Daniel Bristot de Oliveira
2021-05-27 11:58 ` Juri Lelli
2021-05-27 12:29 ` Daniel Bristot de Oliveira
2021-06-03 21:17 ` Steven Rostedt
2021-06-04 15:31 ` Daniel Bristot de Oliveira
2021-05-14 20:51 ` [PATCH V3 5/9] tracing/trace: Add a generic function to read/write u64 values from tracefs Daniel Bristot de Oliveira
2021-06-03 21:22 ` Steven Rostedt
2021-06-04 16:05 ` Daniel Bristot de Oliveira
2021-06-04 16:18 ` Steven Rostedt
2021-06-04 16:34 ` Daniel Bristot de Oliveira
2021-05-14 20:51 ` [PATCH V3 6/9] trace/hwlat: Use the generic function to read/write width and window Daniel Bristot de Oliveira
2021-06-03 21:27 ` Steven Rostedt
2021-06-04 16:36 ` Daniel Bristot de Oliveira
2021-06-04 20:50 ` Steven Rostedt
2021-05-14 20:51 ` [PATCH V3 7/9] tracing: Add __print_ns_to_secs() and __print_ns_without_secs() helpers Daniel Bristot de Oliveira
2021-06-03 21:29 ` Steven Rostedt
2021-06-04 4:19 ` Joe Perches
2021-06-04 16:21 ` Steven Rostedt
2021-06-04 19:09 ` [PATCH] treewide: Add missing semicolons to __assign_str uses Joe Perches
2021-06-04 19:38 ` Joe Perches
2021-06-07 23:18 ` Jason Gunthorpe
2021-06-12 15:42 ` [PATCH V2] " Joe Perches
2021-06-12 23:11 ` Steven Rostedt
2021-06-30 11:28 ` Joe Perches
2021-06-30 12:22 ` Steven Rostedt
2021-06-04 16:07 ` Daniel Bristot de Oliveira [this message]
2021-05-14 20:51 ` [PATCH V3 8/9] tracing: Add osnoise tracer Daniel Bristot de Oliveira
2021-06-03 21:31 ` Steven Rostedt
2021-06-04 21:28 ` Steven Rostedt
2021-06-07 12:00 ` Daniel Bristot de Oliveira
2021-06-07 15:47 ` Steven Rostedt
2021-06-08 15:24 ` Daniel Bristot de Oliveira
2021-06-08 17:17 ` Daniel Bristot de Oliveira
2021-06-08 17:39 ` Steven Rostedt
2021-06-08 19:33 ` Daniel Bristot de Oliveira
2021-06-08 19:42 ` Steven Rostedt
2021-06-09 12:14 ` Daniel Bristot de Oliveira
2021-06-09 13:03 ` Steven Rostedt
2021-06-09 13:44 ` Daniel Bristot de Oliveira
2021-05-14 20:51 ` [PATCH V3 9/9] tracing: Add timerlat tracer Daniel Bristot de Oliveira
2021-06-08 1:36 ` Steven Rostedt
2021-06-11 12:59 ` Daniel Bristot de Oliveira
2021-06-11 20:03 ` Steven Rostedt
2021-06-12 9:41 ` Daniel Bristot de Oliveira
2021-06-12 23:06 ` Steven Rostedt
2021-06-11 14:13 ` Daniel Bristot de Oliveira
2021-06-11 20:48 ` Steven Rostedt
2021-06-12 8:47 ` Daniel Bristot de Oliveira
2021-06-12 23:09 ` Steven Rostedt
2021-06-15 8:18 ` Daniel Bristot de Oliveira
2021-05-27 12:07 ` [PATCH V3 0/9] hwlat improvements and osnoise/timerlat tracers Juri Lelli
2021-05-29 2:16 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a343ad15-4deb-ae14-eead-60f7d95fa7d3@redhat.com \
--to=bristot@redhat.com \
--cc=alexandre.chartre@oracle.com \
--cc=bigeasy@linutronix.de \
--cc=corbet@lwn.net \
--cc=jkacur@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kcarcia@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).