From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755527AbdKMUSC (ORCPT ); Mon, 13 Nov 2017 15:18:02 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:10388 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755328AbdKMURt (ORCPT ); Mon, 13 Nov 2017 15:17:49 -0500 Subject: Re: [PATCH 2/2] clk: ti: dra7-atl-clock: fix child-node lookups To: Johan Hovold , Stephen Boyd CC: Andy Gross , David Brown , Michael Turquette , Tero Kristo , , , , , stable References: <20171111162929.11722-1-johan@kernel.org> <20171111162929.11722-2-johan@kernel.org> From: Peter Ujfalusi Message-ID: Date: Mon, 13 Nov 2017 22:15:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171111162929.11722-2-johan@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/2017 06:29 PM, Johan Hovold wrote: > Fix child node-lookup during probe, which ended up searching the whole > device tree depth-first starting at parent rather than just matching on > its children. > > Note that the original premature free of the parent node has already > been fixed separately, but that fix was apparently never backported to > stable. Acked-by: Peter Ujfalusi > > Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)") > Fixes: 660e15519399 ("clk: ti: dra7-atl-clock: Fix of_node reference counting") > Cc: stable # 3.16: 660e15519399 > Cc: Peter Ujfalusi > Signed-off-by: Johan Hovold > --- > drivers/clk/ti/clk-dra7-atl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c > index 13eb04f72389..148815470431 100644 > --- a/drivers/clk/ti/clk-dra7-atl.c > +++ b/drivers/clk/ti/clk-dra7-atl.c > @@ -274,8 +274,7 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev) > > /* Get configuration for the ATL instances */ > snprintf(prop, sizeof(prop), "atl%u", i); > - of_node_get(node); > - cfg_node = of_find_node_by_name(node, prop); > + cfg_node = of_get_child_by_name(node, prop); > if (cfg_node) { > ret = of_property_read_u32(cfg_node, "bws", > &cdesc->bws); > -- Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki