* linux-next: Fixes tag needs some work in the ipsec tree
@ 2021-09-26 20:49 Stephen Rothwell
2021-09-27 7:55 ` Nicolas Dichtel
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2021-09-26 20:49 UTC (permalink / raw)
To: Steffen Klassert
Cc: Nicolas Dichtel, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
Hi all,
In commit
93ec1320b017 ("xfrm: fix rcu lock in xfrm_notify_userpolicy()")
Fixes tag
Fixes: 703b94b93c19 ("xfrm: notify default policy on update")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 88d0adb5f13b ("xfrm: notify default policy on update")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ipsec tree
2021-09-26 20:49 linux-next: Fixes tag needs some work in the ipsec tree Stephen Rothwell
@ 2021-09-27 7:55 ` Nicolas Dichtel
2021-09-27 11:18 ` Steffen Klassert
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Dichtel @ 2021-09-27 7:55 UTC (permalink / raw)
To: Stephen Rothwell, Steffen Klassert
Cc: Linux Kernel Mailing List, Linux Next Mailing List
Hi Stephen,
Le 26/09/2021 à 22:49, Stephen Rothwell a écrit :
> Hi all,
>
> In commit
>
> 93ec1320b017 ("xfrm: fix rcu lock in xfrm_notify_userpolicy()")
>
> Fixes tag
>
> Fixes: 703b94b93c19 ("xfrm: notify default policy on update")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 88d0adb5f13b ("xfrm: notify default policy on update")
>
In fact, the sha1 comes from the ipsec tree, which is regularly rebased.
The original patch is only in this tree for now.
Steffen, maybe this fix could be squashed with the original commit?
Regards,
Nicolas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ipsec tree
2021-09-27 7:55 ` Nicolas Dichtel
@ 2021-09-27 11:18 ` Steffen Klassert
2021-09-27 12:37 ` Nicolas Dichtel
0 siblings, 1 reply; 6+ messages in thread
From: Steffen Klassert @ 2021-09-27 11:18 UTC (permalink / raw)
To: Nicolas Dichtel
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
On Mon, Sep 27, 2021 at 09:55:07AM +0200, Nicolas Dichtel wrote:
> Hi Stephen,
>
> Le 26/09/2021 à 22:49, Stephen Rothwell a écrit :
> > Hi all,
> >
> > In commit
> >
> > 93ec1320b017 ("xfrm: fix rcu lock in xfrm_notify_userpolicy()")
> >
> > Fixes tag
> >
> > Fixes: 703b94b93c19 ("xfrm: notify default policy on update")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 88d0adb5f13b ("xfrm: notify default policy on update")
> >
> In fact, the sha1 comes from the ipsec tree, which is regularly rebased.
The testing branch of the ipsec tree might be rebased if I have
a bad commit there. The master branch of the ipsec tree will not
be rebased, as this branch is publicly used.
> The original patch is only in this tree for now.
> Steffen, maybe this fix could be squashed with the original commit?
As said, I never rebased the master branch so far and would only do
so in case of emergency.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Fixes tag needs some work in the ipsec tree
2021-09-27 11:18 ` Steffen Klassert
@ 2021-09-27 12:37 ` Nicolas Dichtel
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Dichtel @ 2021-09-27 12:37 UTC (permalink / raw)
To: Steffen Klassert
Cc: Stephen Rothwell, Linux Kernel Mailing List, Linux Next Mailing List
Le 27/09/2021 à 13:18, Steffen Klassert a écrit :
> On Mon, Sep 27, 2021 at 09:55:07AM +0200, Nicolas Dichtel wrote:
>> Hi Stephen,
>>
>> Le 26/09/2021 à 22:49, Stephen Rothwell a écrit :
>>> Hi all,
>>>
>>> In commit
>>>
>>> 93ec1320b017 ("xfrm: fix rcu lock in xfrm_notify_userpolicy()")
>>>
>>> Fixes tag
>>>
>>> Fixes: 703b94b93c19 ("xfrm: notify default policy on update")
>>>
>>> has these problem(s):
>>>
>>> - Target SHA1 does not exist
>>>
>>> Maybe you meant
>>>
>>> Fixes: 88d0adb5f13b ("xfrm: notify default policy on update")
>>>
>> In fact, the sha1 comes from the ipsec tree, which is regularly rebased.
>
> The testing branch of the ipsec tree might be rebased if I have
> a bad commit there. The master branch of the ipsec tree will not
> be rebased, as this branch is publicly used.
>
>> The original patch is only in this tree for now.
>> Steffen, maybe this fix could be squashed with the original commit?
>
> As said, I never rebased the master branch so far and would only do
> so in case of emergency.
>
Ok, thanks for the clarification and sorry for this wrong sha1, which probably
comes from my tree.
Regards,
Nicolas
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the ipsec tree
@ 2020-04-20 10:57 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2020-04-20 10:57 UTC (permalink / raw)
To: Steffen Klassert
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Antony Antony
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
Hi all,
In commit
29e4276667e2 ("xfrm: fix error in comment")
Fixes tag
Fixes: d77e38e612a ("xfrm: Add an IPsec hardware offloading API")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: Fixes tag needs some work in the ipsec tree
@ 2019-05-28 21:48 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2019-05-28 21:48 UTC (permalink / raw)
To: Steffen Klassert
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jeremy Sowden
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
Hi Steffen,
In commit
7c80eb1c7e2b ("af_key: fix leaks in key_pol_get_resp and dump_sp.")
Fixes tag
Fixes: 55569ce256ce ("Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx.")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-27 12:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-26 20:49 linux-next: Fixes tag needs some work in the ipsec tree Stephen Rothwell
2021-09-27 7:55 ` Nicolas Dichtel
2021-09-27 11:18 ` Steffen Klassert
2021-09-27 12:37 ` Nicolas Dichtel
-- strict thread matches above, loose matches on Subject: below --
2020-04-20 10:57 Stephen Rothwell
2019-05-28 21:48 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).