From: Ezequiel Garcia <ezequiel@collabora.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, Hans Verkuil <hverkuil@xs4all.nl>,
Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH] cedrus: Drop unneeded CONFIG_OF dependency
Date: Fri, 03 Apr 2020 09:21:49 -0300 [thread overview]
Message-ID: <a36a825bc048821b4b7088feea71bd31e9e17211.camel@collabora.com> (raw)
In-Reply-To: <20200403082206.GA626942@aptenodytes>
On Fri, 2020-04-03 at 10:22 +0200, Paul Kocialkowski wrote:
> Hi Ezequiel,
>
> On Thu 02 Apr 20, 16:46, Ezequiel Garcia wrote:
> > The driver is perfectly capable of being built without CONFIG_OF.
> > Remove this dependency, which is useful for compile-only tests.
>
> Thanks for the patch!
>
> Alas, the driver won't do anything useful without OF enabled, so it seems
> useful to keep that dependency.
>
I'm not convinced about this argument, I like to have
dependencies on things the driver needs to compile
(except the machine option, see below).
> I would suggest making this a: depends on OF || COMPILE_TEST
> instead. What do you think?
>
Although there are a handful, I don't see many drivers doing that.
To be honest, I don't like this much.
Also, if you want to make sure this driver can only be selected
where it makes sense, you consider having a ARCH_SUNXI || COMPILE_TEST.
IMO, the dependency on OF should be dropped as well.
Cheers,
Eze
> Cheers,
>
> Paul
>
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> > drivers/staging/media/sunxi/cedrus/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/sunxi/cedrus/Kconfig b/drivers/staging/media/sunxi/cedrus/Kconfig
> > index 17733e9a088f..59b8d1b29865 100644
> > --- a/drivers/staging/media/sunxi/cedrus/Kconfig
> > +++ b/drivers/staging/media/sunxi/cedrus/Kconfig
> > @@ -3,7 +3,6 @@ config VIDEO_SUNXI_CEDRUS
> > tristate "Allwinner Cedrus VPU driver"
> > depends on VIDEO_DEV && VIDEO_V4L2 && MEDIA_CONTROLLER
> > depends on HAS_DMA
> > - depends on OF
> > depends on MEDIA_CONTROLLER_REQUEST_API
> > select SUNXI_SRAM
> > select VIDEOBUF2_DMA_CONTIG
> > --
> > 2.26.0.rc2
> >
next prev parent reply other threads:[~2020-04-03 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 19:46 [PATCH] cedrus: Drop unneeded CONFIG_OF dependency Ezequiel Garcia
2020-04-03 8:22 ` Paul Kocialkowski
2020-04-03 12:21 ` Ezequiel Garcia [this message]
2020-04-20 15:29 ` Paul Kocialkowski
2020-04-21 3:43 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a36a825bc048821b4b7088feea71bd31e9e17211.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).