From: "Andreas Färber" <afaerber@suse.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Mark Brown <broonie@kernel.org>
Cc: lee.jones@linaro.org, lgirdwood@gmail.com, robh+dt@kernel.org,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
thomas.liau@actions-semi.com, devicetree@vger.kernel.org,
linus.walleij@linaro.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs
Date: Mon, 17 Jun 2019 18:38:53 +0200 [thread overview]
Message-ID: <a38d26d1-213c-31ef-9cc7-1d4bdda4ceab@suse.de> (raw)
In-Reply-To: <20190617163413.GA16152@Mani-XPS-13-9360>
Hi,
Am 17.06.19 um 18:34 schrieb Manivannan Sadhasivam:
> On Mon, Jun 17, 2019 at 05:30:15PM +0100, Mark Brown wrote:
>> On Mon, Jun 17, 2019 at 09:20:10PM +0530, Manivannan Sadhasivam wrote:
>>
>>> +++ b/drivers/regulator/atc260x-regulator.c
>>> @@ -0,0 +1,389 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * Regulator driver for ATC260x PMICs
>>
>> Please make the entire comment a C++ one so this looks more intentional.
No, this is intentional and the official style requested by GregKH.
He suggested I patch the SPDX documentation to make this clearer, but I
did not find time for this yet (and am not the one making this rule).
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2019-06-17 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 15:50 [PATCH 0/4] Add MFD/Regulator support for ATC260x PMICs Manivannan Sadhasivam
2019-06-17 15:50 ` [PATCH 1/4] dt-bindings: mfd: Add Actions Semi ATC260x PMIC binding Manivannan Sadhasivam
2019-07-09 16:48 ` Rob Herring
2019-06-17 15:50 ` [PATCH 2/4] mfd: Add initial MFD driver for ATC260x PMICs Manivannan Sadhasivam
2019-06-26 6:56 ` Lee Jones
2019-06-17 15:50 ` [PATCH 3/4] regulator: Add regulator " Manivannan Sadhasivam
2019-06-17 16:30 ` Mark Brown
2019-06-17 16:34 ` Manivannan Sadhasivam
2019-06-17 16:38 ` Andreas Färber [this message]
2019-06-17 16:54 ` Mark Brown
2019-06-17 20:30 ` Greg Kroah-Hartman
2019-06-17 17:03 ` Mark Brown
2019-06-17 17:24 ` Manivannan Sadhasivam
2019-06-18 8:13 ` Lee Jones
2019-06-18 10:44 ` Mark Brown
2019-06-17 15:50 ` [PATCH 4/4] MAINTAINERS: Add entry for ATC260x PMIC Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a38d26d1-213c-31ef-9cc7-1d4bdda4ceab@suse.de \
--to=afaerber@suse.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=thomas.liau@actions-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).