From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933212AbdBHJNq (ORCPT ); Wed, 8 Feb 2017 04:13:46 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:33535 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932969AbdBHJMw (ORCPT ); Wed, 8 Feb 2017 04:12:52 -0500 From: Hugues FRUCHET To: Loic PALLARDY , "bjorn.andersson@linaro.org" , "ohad@wizery.com" , "lee.jones@linaro.org" CC: "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@stlinux.com" , Patrice CHOTARD , "peter.griffin@linaro.org" Subject: Re: [v3,3/4] remoteproc: st: add da to va support Thread-Topic: [v3,3/4] remoteproc: st: add da to va support Thread-Index: AQHSgenPxCOBVv9uDkqD011YZrlojw== Date: Wed, 8 Feb 2017 09:00:35 +0000 Message-ID: References: <1485866156-6364-4-git-send-email-loic.pallardy@st.com> In-Reply-To: <1485866156-6364-4-git-send-email-loic.pallardy@st.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.47] Content-Type: text/plain; charset="utf-8" Content-ID: <23D1207C328BC6459E2C115A28F7FC0A@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-08_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v189Dopv002501 On 01/31/2017 01:35 PM, Loic PALLARDY wrote: > ST remoteproc driver needs to provide information about > carveout memory region to allow remoteproc core to load > firmware and access trace buffer. > > Signed-off-by: Loic Pallardy Acked-and-tested-by: Hugues Fruchet Tested on B2260 ST Platform with st-delta video decoder V4L2 kernel driver (http://www.mail-archive.com/linux-media@vger.kernel.org/msg107644.html). > --- > Changes since V2: > - fix checkpatch --strict warning > --- > drivers/remoteproc/st_remoteproc.c | 43 ++++++++++++++++++++++++++++++++------ > 1 file changed, 37 insertions(+), 6 deletions(-) > > diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c > index f1e9339..80f8118 100644 > --- a/drivers/remoteproc/st_remoteproc.c > +++ b/drivers/remoteproc/st_remoteproc.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -53,6 +54,10 @@ struct st_rproc { > struct mbox_chan *mbox_chan[ST_RPROC_MAX_VRING * MBOX_MAX]; > struct mbox_client mbox_client_vq0; > struct mbox_client mbox_client_vq1; > + phys_addr_t mem_phys; > + phys_addr_t mem_reloc; > + void *mem_region; > + size_t mem_size; > }; > > static void st_rproc_mbox_callback(struct device *dev, u32 msg) > @@ -157,10 +162,23 @@ static int st_rproc_stop(struct rproc *rproc) > return sw_err ?: pwr_err; > } > > +static void *st_proc_da_to_va(struct rproc *rproc, u64 da, int len) > +{ > + struct st_rproc *ddata = rproc->priv; > + int offset; > + > + offset = da - ddata->mem_reloc; > + if (offset < 0 || offset + len > ddata->mem_size) > + return NULL; > + > + return ddata->mem_region + offset; > +} > + > static struct rproc_ops st_rproc_ops = { > .kick = st_rproc_kick, > .start = st_rproc_start, > .stop = st_rproc_stop, > + .da_to_va = st_proc_da_to_va, > }; > > /* > @@ -208,7 +226,8 @@ static int st_rproc_parse_dt(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct rproc *rproc = platform_get_drvdata(pdev); > struct st_rproc *ddata = rproc->priv; > - struct device_node *np = dev->of_node; > + struct device_node *np = dev->of_node, *node; > + struct resource res; > int err; > > if (ddata->config->sw_reset) { > @@ -252,10 +271,24 @@ static int st_rproc_parse_dt(struct platform_device *pdev) > return -EINVAL; > } > > - err = of_reserved_mem_device_init(dev); > - if (err) { > - dev_err(dev, "Failed to obtain shared memory\n"); > + node = of_parse_phandle(np, "memory-region", 0); > + if (!node) { > + dev_err(dev, "No memory-region specified\n"); > + return -EINVAL; > + } > + > + err = of_address_to_resource(node, 0, &res); > + if (err) > return err; > + > + ddata->mem_phys = res.start; > + ddata->mem_reloc = res.start; > + ddata->mem_size = resource_size(&res); > + ddata->mem_region = devm_ioremap_wc(dev, ddata->mem_phys, ddata->mem_size); > + if (!ddata->mem_region) { > + dev_err(dev, "Unable to map memory region: %pa+%zx\n", > + &res.start, ddata->mem_size); > + return -EBUSY; > } > > err = clk_prepare(ddata->clk); > @@ -385,8 +418,6 @@ static int st_rproc_remove(struct platform_device *pdev) > > clk_disable_unprepare(ddata->clk); > > - of_reserved_mem_device_release(&pdev->dev); > - > for (i = 0; i < ST_RPROC_MAX_VRING * MBOX_MAX; i++) > mbox_free_channel(ddata->mbox_chan[i]); > >