From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AEADC47425 for ; Wed, 30 Sep 2020 09:07:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE65320719 for ; Wed, 30 Sep 2020 09:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728709AbgI3JHx (ORCPT ); Wed, 30 Sep 2020 05:07:53 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14788 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725776AbgI3JHw (ORCPT ); Wed, 30 Sep 2020 05:07:52 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 7D8F18A9CA45CAADD438; Wed, 30 Sep 2020 17:07:49 +0800 (CST) Received: from [10.174.179.33] (10.174.179.33) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Wed, 30 Sep 2020 17:07:42 +0800 Subject: Re: [PATCH] ACPI / NUMA: Add stub function for pxm_to_node To: Nathan Chancellor , Robert Moore , Erik Kaneda , "Rafael J. Wysocki" , Len Brown CC: Jonathan Cameron , , , References: <20200928194554.3423466-1-natechancellor@gmail.com> From: Hanjun Guo Message-ID: Date: Wed, 30 Sep 2020 17:07:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200928194554.3423466-1-natechancellor@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.33] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/29 3:45, Nathan Chancellor wrote: > After commit 01feba590cd6 ("ACPI: Do not create new NUMA domains from > ACPI static tables that are not SRAT"): > > $ scripts/config --file arch/x86/configs/x86_64_defconfig -d NUMA -e ACPI_NFIT > > $ make -skj"$(nproc)" distclean defconfig drivers/acpi/nfit/ > drivers/acpi/nfit/core.c: In function ‘acpi_nfit_register_region’: > drivers/acpi/nfit/core.c:3010:27: error: implicit declaration of > function ‘pxm_to_node’; did you mean ‘xa_to_node’? > [-Werror=implicit-function-declaration] > 3010 | ndr_desc->target_node = pxm_to_node(spa->proximity_domain); > | ^~~~~~~~~~~ > | xa_to_node > cc1: some warnings being treated as errors > ... > > Add a stub function like acpi_map_pxm_to_node had so that the build > continues to work. > > Fixes: 01feba590cd6 ("ACPI: Do not create new NUMA domains from ACPI static tables that are not SRAT") > Signed-off-by: Nathan Chancellor > --- > > I am not sure if this is the right place or value for this. It looks > like there is going to be another stub function added here, which is > going through -mm: > > https://lkml.kernel.org/r/159643094925.4062302.14979872973043772305.stgit@dwillia2-desk3.amr.corp.intel.com > > include/acpi/acpi_numa.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/acpi/acpi_numa.h b/include/acpi/acpi_numa.h > index fdebcfc6c8df..09eb3bc20ff5 100644 > --- a/include/acpi/acpi_numa.h > +++ b/include/acpi/acpi_numa.h > @@ -22,5 +22,10 @@ extern int acpi_numa __initdata; > extern void bad_srat(void); > extern int srat_disabled(void); > > +#else /* CONFIG_ACPI_NUMA */ > +static inline int pxm_to_node(int pxm) > +{ > + return 0; > +} > #endif /* CONFIG_ACPI_NUMA */ > #endif /* __ACP_NUMA_H */ Looks good to me, Reviewed-by: Hanjun Guo