From: Hannes Reinecke <hare@suse.de>
To: Johannes Thumshirn <jthumshirn@suse.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
ard <ard@kwaak.net>
Subject: Re: [PATCH 1/3] fcoe: fix use-after-free in fcoe_ctlr_els_send
Date: Wed, 1 Aug 2018 08:30:13 +0200 [thread overview]
Message-ID: <a3ad59a7-3ccb-46e7-60b6-6ce073417564@suse.de> (raw)
In-Reply-To: <20180731134603.20089-2-jthumshirn@suse.de>
On 07/31/2018 03:46 PM, Johannes Thumshirn wrote:
> KASAN reports a use-after-free in fcoe_ctlr_els_send() when we're
> sending a LOGO and have FIP debugging enabled. This is because we're
> first freeing the skb and then printing the frame's DID. But the DID
> is a member of the FC frame header which in turn is the skb's payload.
>
> Exchange the debug print and kfree_skb() calls so we're not touching
> the freed data.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/scsi/fcoe/fcoe_ctlr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
> index ea23c8dffc25..ceb35ebbeb8f 100644
> --- a/drivers/scsi/fcoe/fcoe_ctlr.c
> +++ b/drivers/scsi/fcoe/fcoe_ctlr.c
> @@ -799,9 +799,9 @@ int fcoe_ctlr_els_send(struct fcoe_ctlr *fip, struct fc_lport *lport,
> fip->send(fip, skb);
> return -EINPROGRESS;
> drop:
> - kfree_skb(skb);
> LIBFCOE_FIP_DBG(fip, "drop els_send op %u d_id %x\n",
> op, ntoh24(fh->fh_d_id));
> + kfree_skb(skb);
> return -EINVAL;
> }
> EXPORT_SYMBOL(fcoe_ctlr_els_send);
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-08-01 6:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 13:46 [PATCH 0/3] scsi: fcoe: memleak fixes Johannes Thumshirn
2018-07-31 13:46 ` [PATCH 1/3] fcoe: fix use-after-free in fcoe_ctlr_els_send Johannes Thumshirn
2018-08-01 6:30 ` Hannes Reinecke [this message]
2018-07-31 13:46 ` [PATCH 2/3] scsi: fcoe: drop frames in ELS LOGO error path Johannes Thumshirn
2018-08-01 6:30 ` Hannes Reinecke
2018-07-31 13:46 ` [PATCH 3/3] scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO Johannes Thumshirn
2018-08-01 6:31 ` Hannes Reinecke
2018-08-06 9:25 ` [PATCH 0/3] scsi: fcoe: memleak fixes Johannes Thumshirn
2018-08-06 13:22 ` ard
2018-08-06 13:27 ` Johannes Thumshirn
2018-08-06 14:24 ` ard
2018-08-07 6:54 ` Johannes Thumshirn
2018-08-07 9:26 ` ard
2018-08-07 9:57 ` ard
2018-08-07 16:04 ` ard
2018-08-09 10:01 ` ard
2018-08-09 8:05 ` Johannes Thumshirn
2018-08-09 9:52 ` Martin K. Petersen
2018-08-09 9:56 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ad59a7-3ccb-46e7-60b6-6ce073417564@suse.de \
--to=hare@suse.de \
--cc=ard@kwaak.net \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).