* [PATCH] kconfig: add build-only configurator targets
@ 2018-08-15 0:36 Randy Dunlap
2018-08-16 3:27 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2018-08-15 0:36 UTC (permalink / raw)
To: linux-kbuild, LKML, Masahiro Yamada
From: Randy Dunlap <rdunlap@infradead.org>
Add build-only targets for build_menuconfig, build_nconfig,
build_xconfig, and build_gconfig.
(targets must end in "config" to qualify in top-level Makefile)
This allows these target to be built without execution (e.g., to
look for errors or warnings) and/or to be built and checked by sparse.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
scripts/kconfig/Makefile | 8 ++++++++
1 file changed, 8 insertions(+)
--- linux-next-20180814.orig/scripts/kconfig/Makefile
+++ linux-next-20180814/scripts/kconfig/Makefile
@@ -33,6 +33,14 @@ config: $(obj)/conf
nconfig: $(obj)/nconf
$< $(silent) $(Kconfig)
+build_menuconfig: $(obj)/mconf
+
+build_nconfig: $(obj)/nconf
+
+build_gconfig: $(obj)/gconf
+
+build_xconfig: $(obj)/qconf
+
localyesconfig localmodconfig: $(obj)/conf
$(Q)perl $(srctree)/$(src)/streamline_config.pl --$@ $(srctree) $(Kconfig) > .tmp.config
$(Q)if [ -f .config ]; then \
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kconfig: add build-only configurator targets
2018-08-15 0:36 [PATCH] kconfig: add build-only configurator targets Randy Dunlap
@ 2018-08-16 3:27 ` Masahiro Yamada
2018-08-16 16:30 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2018-08-16 3:27 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kbuild, LKML
2018-08-15 9:36 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Add build-only targets for build_menuconfig, build_nconfig,
> build_xconfig, and build_gconfig.
> (targets must end in "config" to qualify in top-level Makefile)
>
> This allows these target to be built without execution (e.g., to
> look for errors or warnings) and/or to be built and checked by sparse.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> scripts/kconfig/Makefile | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> --- linux-next-20180814.orig/scripts/kconfig/Makefile
> +++ linux-next-20180814/scripts/kconfig/Makefile
> @@ -33,6 +33,14 @@ config: $(obj)/conf
> nconfig: $(obj)/nconf
> $< $(silent) $(Kconfig)
>
> +build_menuconfig: $(obj)/mconf
> +
> +build_nconfig: $(obj)/nconf
> +
> +build_gconfig: $(obj)/gconf
> +
> +build_xconfig: $(obj)/qconf
> +
> localyesconfig localmodconfig: $(obj)/conf
> $(Q)perl $(srctree)/$(src)/streamline_config.pl --$@ $(srctree) $(Kconfig) > .tmp.config
> $(Q)if [ -f .config ]; then \
>
OK, seems useful,
but these should be phony targets.
May I squash the following change?
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index c0ca9ea..f7bdcc9 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -3,7 +3,8 @@
# Kernel configuration targets
# These targets are used from top-level makefile
-PHONY += xconfig gconfig menuconfig config localmodconfig localyesconfig
+PHONY += xconfig gconfig menuconfig config localmodconfig localyesconfig \
+ build_menuconfig build_nconfig build_gconfig build_xconfig
ifdef KBUILD_KCONFIG
Kconfig := $(KBUILD_KCONFIG)
--
Best Regards
Masahiro Yamada
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kconfig: add build-only configurator targets
2018-08-16 3:27 ` Masahiro Yamada
@ 2018-08-16 16:30 ` Randy Dunlap
2018-08-17 1:55 ` Masahiro Yamada
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2018-08-16 16:30 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild, LKML
On 08/15/2018 08:27 PM, Masahiro Yamada wrote:
> 2018-08-15 9:36 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Add build-only targets for build_menuconfig, build_nconfig,
>> build_xconfig, and build_gconfig.
>> (targets must end in "config" to qualify in top-level Makefile)
>>
>> This allows these target to be built without execution (e.g., to
>> look for errors or warnings) and/or to be built and checked by sparse.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> ---
>> scripts/kconfig/Makefile | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> --- linux-next-20180814.orig/scripts/kconfig/Makefile
>> +++ linux-next-20180814/scripts/kconfig/Makefile
>> @@ -33,6 +33,14 @@ config: $(obj)/conf
>> nconfig: $(obj)/nconf
>> $< $(silent) $(Kconfig)
>>
>> +build_menuconfig: $(obj)/mconf
>> +
>> +build_nconfig: $(obj)/nconf
>> +
>> +build_gconfig: $(obj)/gconf
>> +
>> +build_xconfig: $(obj)/qconf
>> +
>> localyesconfig localmodconfig: $(obj)/conf
>> $(Q)perl $(srctree)/$(src)/streamline_config.pl --$@ $(srctree) $(Kconfig) > .tmp.config
>> $(Q)if [ -f .config ]; then \
>>
>
>
> OK, seems useful,
> but these should be phony targets.
>
> May I squash the following change?
>
Of course. Thanks.
>
> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> index c0ca9ea..f7bdcc9 100644
> --- a/scripts/kconfig/Makefile
> +++ b/scripts/kconfig/Makefile
> @@ -3,7 +3,8 @@
> # Kernel configuration targets
> # These targets are used from top-level makefile
>
> -PHONY += xconfig gconfig menuconfig config localmodconfig localyesconfig
> +PHONY += xconfig gconfig menuconfig config localmodconfig localyesconfig \
> + build_menuconfig build_nconfig build_gconfig build_xconfig
>
> ifdef KBUILD_KCONFIG
> Kconfig := $(KBUILD_KCONFIG)
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kconfig: add build-only configurator targets
2018-08-16 16:30 ` Randy Dunlap
@ 2018-08-17 1:55 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2018-08-17 1:55 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kbuild, LKML
2018-08-17 1:30 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
> On 08/15/2018 08:27 PM, Masahiro Yamada wrote:
>> 2018-08-15 9:36 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>>
>>> Add build-only targets for build_menuconfig, build_nconfig,
>>> build_xconfig, and build_gconfig.
>>> (targets must end in "config" to qualify in top-level Makefile)
>>>
>>> This allows these target to be built without execution (e.g., to
>>> look for errors or warnings) and/or to be built and checked by sparse.
>>>
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> ---
Applied to linux-kbuild. Thanks!
>>> scripts/kconfig/Makefile | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> --- linux-next-20180814.orig/scripts/kconfig/Makefile
>>> +++ linux-next-20180814/scripts/kconfig/Makefile
>>> @@ -33,6 +33,14 @@ config: $(obj)/conf
>>> nconfig: $(obj)/nconf
>>> $< $(silent) $(Kconfig)
>>>
>>> +build_menuconfig: $(obj)/mconf
>>> +
>>> +build_nconfig: $(obj)/nconf
>>> +
>>> +build_gconfig: $(obj)/gconf
>>> +
>>> +build_xconfig: $(obj)/qconf
>>> +
>>> localyesconfig localmodconfig: $(obj)/conf
>>> $(Q)perl $(srctree)/$(src)/streamline_config.pl --$@ $(srctree) $(Kconfig) > .tmp.config
>>> $(Q)if [ -f .config ]; then \
>>>
>>
>>
>> OK, seems useful,
>> but these should be phony targets.
>>
>> May I squash the following change?
>>
>
> Of course. Thanks.
>
>>
>> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
>> index c0ca9ea..f7bdcc9 100644
>> --- a/scripts/kconfig/Makefile
>> +++ b/scripts/kconfig/Makefile
>> @@ -3,7 +3,8 @@
>> # Kernel configuration targets
>> # These targets are used from top-level makefile
>>
>> -PHONY += xconfig gconfig menuconfig config localmodconfig localyesconfig
>> +PHONY += xconfig gconfig menuconfig config localmodconfig localyesconfig \
>> + build_menuconfig build_nconfig build_gconfig build_xconfig
>>
>> ifdef KBUILD_KCONFIG
>> Kconfig := $(KBUILD_KCONFIG)
>
>
> --
> ~Randy
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-17 1:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-15 0:36 [PATCH] kconfig: add build-only configurator targets Randy Dunlap
2018-08-16 3:27 ` Masahiro Yamada
2018-08-16 16:30 ` Randy Dunlap
2018-08-17 1:55 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).