From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647E3C433F5 for ; Wed, 19 Jan 2022 11:42:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354300AbiASLm3 (ORCPT ); Wed, 19 Jan 2022 06:42:29 -0500 Received: from mxout03.lancloud.ru ([45.84.86.113]:32826 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236274AbiASLmT (ORCPT ); Wed, 19 Jan 2022 06:42:19 -0500 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru 3B47720D46BF Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= CC: Greg Kroah-Hartman , Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Andy Shevchenko , Joakim Zhang , Guenter Roeck , Thierry Reding , , , Miquel Raynal , , , Lee Jones , , "Khuong Dinh" , Florian Fainelli , Matthias Schiffer , Kamal Dasu , "Jiri Slaby" , Bartosz Golaszewski , "Daniel Lezcano" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Jaroslav Kysela" , , Hans de Goede , Robert Richter , Saravanan Sekar , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , "Sebastian Reichel" , Matthias Brugger , "Takashi Iwai" , , Benson Leung , , , Tony Luck , Mun Yew Tham , Eric Auger , , Yoshihiro Shimoda , Cornelia Huck , , Liam Girdwood , , , "Vinod Koul" , James Morse , Zha Qipeng , Pengutronix Kernel Team , Richard Weinberger , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , "Brian Norris" , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 14:42:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220119113314.tpqfdgi6nurmzfun@pengutronix.de> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/19/22 2:33 PM, Uwe Kleine-König wrote: [...] >>>>> A possible compromise: We can have both. We rename >>>>> platform_get_irq_optional() to platform_get_irq_silent() (or >>>>> platform_get_irq_silently() if this is preferred) and once all users are >>>>> are changed (which can be done mechanically), we reintroduce a >>>>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>>>> return 0 on not-found, no error message printking). >>>> >>>> Please do not do that as anyone trying to forward-port an old driver >>>> will miss the abi change of functionality and get confused. Make >>>> build-breaking changes, if the way a function currently works is >>>> changed in order to give people a chance. >>> >>> Fine for me. I assume this is a Nack for Sergey's patch? >> >> Which patch do you mean? I'm starting to get really muddled... :-( > > I'm talking about "[PATCH 1/2] platform: make > platform_get_irq_optional() optional" I thought GregKH was talking about your renaming patch... :-/ > because "trying to forward-port an > old driver will miss the abi" applies to it. Mhm... why not tell me right from the start? Jr even tell that to Andy instead of merging his patch, so I wouldn't get sucked into this work? I wouldn't bother with v2 and it would have saved a lot of time spent on email... :-( Do we also remember that "the stable API is a nonsense" thing? :-) > Best regards > Uwe MBR, Sergey