linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Anand Moon <linux.amoon@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Corentin Labbe <clabbe@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCHv1 0/3] Enable crypto module on Amlogic GXBB SoC platform
Date: Wed, 11 Dec 2019 09:53:56 +0100	[thread overview]
Message-ID: <a4610efc-844a-2d43-5db1-cf813102e701@baylibre.com> (raw)
In-Reply-To: <20191211084112.971-1-linux.amoon@gmail.com>

hi,


On 11/12/2019 09:41, Anand Moon wrote:
> Below changes enable cryto module on Amlogic GXBB SoC.
> 
> I was realy happy to get this feature working on Odroid C2 SBC.
> I will try on other SBC in the future.
> 
> Tested with loading tcrypt module.
> # sudo modprobe tcrypt sec=1 mode=200
> [sudo] password for alarm:
> [  903.867059] tcrypt:
> [  903.867059] testing speed of async ecb(aes) (ecb(aes-arm64)) encryption
> [  903.870265] tcrypt: test 0 (128 bit key, 16 byte blocks): 1922107 operations in 1 seconds (30753712 bytes)
> [  904.872802] tcrypt: test 1 (128 bit key, 64 byte blocks): 679032 operations in 1 seconds (43458048 bytes)
> [  905.872717] tcrypt: test 2 (128 bit key, 256 byte blocks): 190190 operations in 1 seconds (48688640 bytes)
> [  906.872793] tcrypt: test 3 (128 bit key, 1024 byte blocks): 49014 operations in 1 seconds (50190336 bytes)
> [  907.872808] tcrypt: test 4 (128 bit key, 1472 byte blocks): 34342 operations in 1 seconds (50551424 bytes)
> [  908.876828] tcrypt: test 5 (128 bit key, 8192 byte blocks): 6199 operations in 1 seconds (50782208 bytes)
> 
> -Anand
> 
> Anand Moon (3):
>   arm64: dts: amlogic: adds crypto hardware node for GXBB SoCs
>   dt-bindings: crypto: Add compatible string for amlogic GXBB SoC
>   crypto: amlogic: Add new compatible string for amlogic GXBB SoC
> 
>  .../devicetree/bindings/crypto/amlogic,gxl-crypto.yaml |  1 +
>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi            | 10 ++++++++++
>  drivers/crypto/amlogic/amlogic-gxl-core.c              |  1 +
>  3 files changed, 12 insertions(+)
> 

Wow, I'm surprised it works on GXBB, Amlogic completely removed HW crypto for GXBB in all their
vendor BSPs, in Linux, U-Boot and ATF chain.

Could you run more tests to be sure it's really functional ?

Neil

  parent reply	other threads:[~2019-12-11  8:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11  8:41 [PATCHv1 0/3] Enable crypto module on Amlogic GXBB SoC platform Anand Moon
2019-12-11  8:41 ` [PATCHv1 1/3] arm64: dts: amlogic: adds crypto hardware node for GXBB SoCs Anand Moon
2019-12-11 10:41   ` Anand Moon
2019-12-11  8:41 ` [PATCHv1 2/3] dt-bindings: crypto: Add compatible string for amlogic GXBB SoC Anand Moon
2019-12-11  8:41 ` [PATCHv1 3/3] crypto: amlogic: Add new " Anand Moon
2019-12-11  8:53 ` Neil Armstrong [this message]
2019-12-11  9:27   ` [PATCHv1 0/3] Enable crypto module on Amlogic GXBB SoC platform Herbert Xu
2019-12-11  9:32     ` Neil Armstrong
2019-12-11 10:05     ` Anand Moon
2019-12-11  9:37   ` Anand Moon
2019-12-11  9:50     ` Herbert Xu
2019-12-11 10:33       ` Anand Moon
2019-12-11 12:15       ` Anand Moon
2019-12-11 12:24         ` Ard Biesheuvel
     [not found]           ` <1229236701.11947072.1576070229564@mail.yahoo.com>
2019-12-11 23:30             ` Martin Blumenstingl
2019-12-12  6:23               ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4610efc-844a-2d43-5db1-cf813102e701@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=clabbe@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).