From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Hugues FRUCHET <hugues.fruchet@st.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>
Cc: "vkoul@kernel.org" <vkoul@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] media: stm32-dcmi: Use dma_request_chan() instead dma_request_slave_channel()
Date: Tue, 7 Jan 2020 12:38:56 +0200 [thread overview]
Message-ID: <a4682783-e966-6176-4ab5-cc9345e3508f@ti.com> (raw)
In-Reply-To: <8229c7ed-b513-6bf8-5684-60d87a92d41f@st.com>
Hi Hugues,
On 07/01/2020 11.46, Hugues FRUCHET wrote:
> Hi Peter,
>
> If not too late, could you change trace to only trig error trace when
> error is not "probe defered" ? See below:
>
> - chan = dma_request_slave_channel(&pdev->dev, "tx");
> - if (!chan) {
> - dev_info(&pdev->dev, "Unable to request DMA channel, defer probing\n");
> - return -EPROBE_DEFER;
> + chan = dma_request_chan(&pdev->dev, "tx");
> + if (IS_ERR(chan)) {
> + if (PTR_ERR(chan) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Unable to request DMA channel\n");
> + return PTR_ERR(chan);
Sure, I don't know how I missed it.
Regards,
- Péter
>
> Best regards,
> Hugues.
>
> On 12/18/19 11:52 AM, Hugues FRUCHET wrote:
>> Thanks for patching Peter,
>>
>> No regression observed on my side.
>>
>> Acked-by: Hugues Fruchet <hugues.fruchet@st.com>
>>
>> Best regards,
>> Hugues.
>>
>> On 12/17/19 11:41 AM, Peter Ujfalusi wrote:
>>> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
>>> eating up the error code.
>>>
>>> By using dma_request_chan() directly the driver can support deferred
>>> probing against DMA.
>>>
>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>> ---
>>> drivers/media/platform/stm32/stm32-dcmi.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
>>> b/drivers/media/platform/stm32/stm32-dcmi.c
>>> index 9392e3409fba..55351872b0c7 100644
>>> --- a/drivers/media/platform/stm32/stm32-dcmi.c
>>> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
>>> @@ -1910,10 +1910,10 @@ static int dcmi_probe(struct platform_device
>>> *pdev)
>>> return PTR_ERR(mclk);
>>> }
>>> - chan = dma_request_slave_channel(&pdev->dev, "tx");
>>> - if (!chan) {
>>> + chan = dma_request_chan(&pdev->dev, "tx");
>>> + if (IS_ERR(chan)) {
>>> dev_info(&pdev->dev, "Unable to request DMA channel, defer
>>> probing\n");
>>> - return -EPROBE_DEFER;
>>> + return PTR_ERR(chan);
>>> }
>>> spin_lock_init(&dcmi->irqlock);
>> >
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-01-07 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 10:41 [PATCH] media: stm32-dcmi: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2019-12-18 10:52 ` Hugues FRUCHET
2020-01-07 9:46 ` Hugues FRUCHET
2020-01-07 10:38 ` Peter Ujfalusi [this message]
2020-01-07 11:08 ` Hugues FRUCHET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4682783-e966-6176-4ab5-cc9345e3508f@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alexandre.torgue@st.com \
--cc=hugues.fruchet@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).