linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Jason Wessel <jason.wessel@windriver.com>
Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdb: kdb_main: mark expected switch fall-throughs
Date: Wed, 15 Aug 2018 15:34:06 +0100	[thread overview]
Message-ID: <a47008fd-1e52-a268-8085-a2cdcd5dce01@linaro.org> (raw)
In-Reply-To: <20180805041454.GA18449@embeddedor.com>

On 05/08/18 05:14, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 115090 ("Missing break in switch")
> Addresses-Coverity-ID: 115091 ("Missing break in switch")
> Addresses-Coverity-ID: 114700 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Adding fall through isn't wrong but its reasonable to ask why there is a 
complex hand unrolled loop here in the first place (and doubly so 
without a comment). The whole switch statement would be much clear 
expressed as:

	for (j=0; j<bytesperword; j++)
		*c++ = printable_char(*cp++);
	addr += bytesperword;


Daniel.


> ---
>   kernel/debug/kdb/kdb_main.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
> index 2ddfce8..2249645 100644
> --- a/kernel/debug/kdb/kdb_main.c
> +++ b/kernel/debug/kdb/kdb_main.c
> @@ -1545,13 +1545,16 @@ static void kdb_md_line(const char *fmtstr, unsigned long addr,
>   				*c++ = printable_char(*cp++);
>   				*c++ = printable_char(*cp++);
>   				addr += 4;
> +				/* fall through */
>   			case 4:
>   				*c++ = printable_char(*cp++);
>   				*c++ = printable_char(*cp++);
>   				addr += 2;
> +				/* fall through */
>   			case 2:
>   				*c++ = printable_char(*cp++);
>   				addr++;
> +				/* fall through */
>   			case 1:
>   				*c++ = printable_char(*cp++);
>   				addr++;
> 


  reply	other threads:[~2018-08-15 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05  4:14 [PATCH] kdb: kdb_main: mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-15 14:34 ` Daniel Thompson [this message]
2018-08-15 14:43   ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a47008fd-1e52-a268-8085-a2cdcd5dce01@linaro.org \
    --to=daniel.thompson@linaro.org \
    --cc=gustavo@embeddedor.com \
    --cc=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).