From: Mathias Nyman <mathias.nyman@intel.com>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Mehta, Sanju" <Sanju.Mehta@amd.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] xhci-pci: Set runtime PM as default policy on all xHC 1.2 or later devices
Date: Mon, 10 Oct 2022 16:57:03 +0300 [thread overview]
Message-ID: <a4849cea-c49f-06a1-4dc2-d619f106bbc9@intel.com> (raw)
In-Reply-To: <MN0PR12MB61013B3B55D21A49C2450B1AE25F9@MN0PR12MB6101.namprd12.prod.outlook.com>
On 7.10.2022 19.42, Limonciello, Mario wrote:
> [Public]
>
>
>
>> -----Original Message-----
>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>> Sent: Friday, October 7, 2022 04:55
>> To: Limonciello, Mario <Mario.Limonciello@amd.com>
>> Cc: Mathias Nyman <mathias.nyman@intel.com>; Mehta, Sanju
>> <Sanju.Mehta@amd.com>; Mathias Nyman
>> <mathias.nyman@linux.intel.com>; Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: Re: [PATCH v2 1/2] xhci-pci: Set runtime PM as default policy on all
>> xHC 1.2 or later devices
>>
>> On Thu, Oct 06, 2022 at 04:15:28PM -0500, Mario Limonciello wrote:
>>> - if (pdev->vendor == PCI_VENDOR_ID_AMD &&
>>> - (pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_1 ||
>>> - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_2 ||
>>> - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_3 ||
>>> - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_4 ||
>>> - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_5 ||
>>> - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_6 ||
>>> - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_7 ||
>>> - pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_8))
>>
>> Can you add a comment here explaining why this is OK? I think it is
>> easier that way to find out why this is here in the future instead of
>> going through the git blame history.
>
> Sure, no problem.
>
> I'll hold off sending a v3 though until you and Mathias can double check
> everything in patch 2/2 is OK to take out and agree with that secondary logic
> change.
>
>>
>>> + if (xhci->hci_version >= 0x102)
Shouldn't this be ">= 0x120"
Thanks
Mathias
next prev parent reply other threads:[~2022-10-10 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 21:15 [PATCH v2 0/2] Enable runtime PM more broadly Mario Limonciello
2022-10-06 21:15 ` [PATCH v2 1/2] xhci-pci: Set runtime PM as default policy on all xHC 1.2 or later devices Mario Limonciello
2022-10-07 9:55 ` Mika Westerberg
2022-10-07 16:42 ` Limonciello, Mario
2022-10-10 13:45 ` Mathias Nyman
2022-10-10 13:57 ` Mathias Nyman [this message]
2022-10-06 21:15 ` [PATCH v2 2/2] xhci-pci: Lower the requirement for runtime PM version to 1.0 Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4849cea-c49f-06a1-4dc2-d619f106bbc9@intel.com \
--to=mathias.nyman@intel.com \
--cc=Mario.Limonciello@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).