From: khsieh@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Sankeerth Billakanti <sbillaka@codeaurora.org>
Subject: Re: [PATCH] drm/msm/dp: Shorten SETUP timeout
Date: Tue, 05 Oct 2021 16:04:40 -0700 [thread overview]
Message-ID: <a4a4980e586a70e3b7de989bc61a3e33@codeaurora.org> (raw)
In-Reply-To: <CAE-0n53FC7JCCJoye_uKeqaLKrZeHXLtvObxWFedaUzjirmBaA@mail.gmail.com>
On 2021-10-05 15:36, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2021-10-05 14:40:38)
>> On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote:
>>
>> > Quoting Bjorn Andersson (2021-10-04 19:37:50)
>> > > Found in the middle of a patch from Sankeerth was the reduction of the
>> > > INIT_SETUP timeout from 10s to 100ms. Upon INIT_SETUP timeout the host
>> > > is initalized and HPD interrupt start to be serviced, so in the case of
>> > > eDP this reduction improves the user experience dramatically - i.e.
>> > > removes 9.9s of bland screen time at boot.
>> > >
>> > > Suggested-by: Sankeerth Billakanti <sbillaka@codeaurora.org>
>> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> > > ---
>> >
>> > Any Fixes tag? BTW, the delay design is pretty convoluted. I had to go
>> > re-read the code a couple times to understand that it's waiting 100ms
>> > times the 'delay' number. Whaaaaat?
>> >
>>
>> I assume you're happy with the current 10s delay on the current
>> devices, so I don't think we should push for this to be backported.
>> I have no need for it to be backported on my side at least.
>>
>
> Sure. Fixes tag != backported to stable trees but it is close.
>
>> > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>>
dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 1); <== to 100ms
This patch will prevent usb3 from working due to dp driver initialize
phy earlier than usb3 which cause timeout error at power up usb3 phy
when both edp and dp are enabled.
I had prepared a patch (drm/msm/dp: do not initialize combo phy until
plugin interrupt) to fix this problem.
Unfortunately, my patch is depend on Bjorn's patch (PATCH v3 3/5]
drm/msm/dp: Support up to 3 DP controllers).
I will submit my patch for review once Bjorn's patches merged in.
Therefore I would think this patch should go after both Bjorn's patches
and my patch.
next prev parent reply other threads:[~2021-10-05 23:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 2:37 [PATCH] drm/msm/dp: Shorten SETUP timeout Bjorn Andersson
2021-10-05 18:45 ` Stephen Boyd
2021-10-05 21:40 ` Bjorn Andersson
2021-10-05 22:36 ` Stephen Boyd
2021-10-05 23:04 ` khsieh [this message]
2021-10-05 23:35 ` Stephen Boyd
2021-10-06 2:10 ` Bjorn Andersson
2021-10-06 15:37 ` khsieh
2021-10-06 17:31 ` Bjorn Andersson
2021-10-07 19:51 ` khsieh
2021-10-07 20:06 ` Bjorn Andersson
2021-10-07 20:28 ` khsieh
2021-10-07 22:34 ` Stephen Boyd
2021-10-08 16:07 ` khsieh
2021-10-08 16:44 ` Bjorn Andersson
2021-10-11 15:24 ` khsieh
2021-10-11 17:30 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4a4980e586a70e3b7de989bc61a3e33@codeaurora.org \
--to=khsieh@codeaurora.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sbillaka@codeaurora.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).