linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Yuyang Du <yuyang.du@intel.com>,
	peterz@infradead.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org
Cc: bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	matt@codeblueprint.co.uk, umgwanakikbuti@gmail.com
Subject: Re: [PATCH v1 02/10] documentation: Add scheduler/sched-avg.txt
Date: Mon, 22 Aug 2016 09:48:51 -0700	[thread overview]
Message-ID: <a4a9e3ac-dbb1-9860-88c9-20ec795eafb7@infradead.org> (raw)
In-Reply-To: <1470788095-2125-3-git-send-email-yuyang.du@intel.com>

On 08/09/16 17:14, Yuyang Du wrote:
> This doc file has the program to generate the constants to compute
> sched averages.
> 
> Signed-off-by: Yuyang Du <yuyang.du@intel.com>
> ---
>  Documentation/scheduler/sched-avg.txt |   94 +++++++++++++++++++++++++++++++++
>  1 file changed, 94 insertions(+)
>  create mode 100644 Documentation/scheduler/sched-avg.txt

I'll confirm that it builds and generates a buildable source file
as long as "u32" is understood (defined/typedef'd).

I would rather see it in tools/ as a C source file with comments as
follows:

// The following program is used to generate the constants for
// computing sched averages.

//	C program (compile with -lm)

> +#include <math.h>
> +#include <stdio.h>

Maybe even add
#include <stdint.h>

and
typedef uint32_t	u32;


thanks,
-- 
~Randy

  reply	other threads:[~2016-08-22 16:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10  0:14 [PATCH v1 00/10] Optimize sched avgs computation and implement flat util hierarchy Yuyang Du
2016-08-10  0:14 ` [PATCH v1 01/10] sched/fair: Chance LOAD_AVG_MAX_N from 345 to 347 Yuyang Du
2016-08-24 16:01   ` Vincent Guittot
2016-08-29  0:07     ` Yuyang Du
2016-08-10  0:14 ` [PATCH v1 02/10] documentation: Add scheduler/sched-avg.txt Yuyang Du
2016-08-22 16:48   ` Randy Dunlap [this message]
2016-08-10  0:14 ` [PATCH v1 03/10] sched/fair: Add static to remove_entity_load_avg() Yuyang Du
2016-08-10  0:14 ` [PATCH v1 04/10] sched/fair: Rename variable names for sched averages Yuyang Du
2016-08-10  0:14 ` [PATCH v1 05/10] sched/fair: Add __always_inline compiler attribute to __accumulate_sum() Yuyang Du
2016-08-10  0:14 ` [PATCH v1 06/10] sched/fair: Optimize __update_sched_avg() Yuyang Du
2016-08-10  0:14 ` [PATCH v1 07/10] sched/fair: Remove useless 64-bit to 32-bit variable conversion Yuyang Du
2016-08-25  7:11   ` Vincent Guittot
2016-08-29  1:00     ` Yuyang Du
2016-08-10  0:14 ` [PATCH v1 08/10] sched/fair: Remove scale_load_down() for load_avg Yuyang Du
2016-08-10  0:14 ` [PATCH v1 09/10] sched/fair: Rename scale_load() and scale_load_down() Yuyang Du
2016-08-10  0:14 ` [PATCH v1 10/10] sched/fair: Implement flat hierarchical structure for util_avg Yuyang Du
2016-08-10  0:23 ` [PATCH v1 00/10] Optimize sched avgs computation and implement flat util hierarchy Yuyang Du
2016-08-22 23:26   ` Yuyang Du
2016-08-23 13:28     ` Vincent Guittot
2016-08-23 14:13       ` Peter Zijlstra
2016-08-23 14:45         ` Vincent Guittot
2016-08-23 15:39           ` Dietmar Eggemann
2016-08-29  1:37             ` Yuyang Du
2016-09-01 18:32               ` Dietmar Eggemann
2016-08-24  8:54           ` Morten Rasmussen
2016-08-24  9:48             ` Vincent Guittot
2016-08-29 19:00             ` Yuyang Du
2016-09-01 14:22               ` Morten Rasmussen
2016-08-23 19:09         ` Yuyang Du
2016-08-23 19:01       ` Yuyang Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4a9e3ac-dbb1-9860-88c9-20ec795eafb7@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@kernel.org \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=umgwanakikbuti@gmail.com \
    --cc=vincent.guittot@linaro.org \
    --cc=yuyang.du@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).