From: Miaohe Lin <linmiaohe@huawei.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
<akpm@linux-foundation.org>
Cc: <ziy@nvidia.com>, <william.kucharski@oracle.com>,
<willy@infradead.org>, <yang.shi@linux.alibaba.com>,
<aneesh.kumar@linux.ibm.com>, <rcampbell@nvidia.com>,
<songliubraving@fb.com>, <kirill.shutemov@linux.intel.com>,
<riel@surriel.com>, <hannes@cmpxchg.org>, <minchan@kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH 0/5] Cleanup and fixup for huge_memory
Date: Wed, 28 Apr 2021 16:32:06 +0800 [thread overview]
Message-ID: <a4e851c9-9754-dd2a-c7a4-37bbefca704a@huawei.com> (raw)
In-Reply-To: <1d86c821-89f6-cc46-ceb4-fac7748212e5@arm.com>
On 2021/4/28 11:10, Anshuman Khandual wrote:
>
>
> On 4/27/21 7:02 PM, Miaohe Lin wrote:
>> Hi all,
>> This series contains cleanups to remove dedicated macro and remove
>> unnecessary tlb_remove_page_size() for huge zero pmd. Also this adds
>> missing read-only THP checking for transparent_hugepage_enabled() and
>> avoids discarding hugepage if other processes are mapping it. More
>> details can be found in the respective changelogs. Thanks!
>>
>> Miaohe Lin (5):
>> mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK
>> mm/huge_memory.c: use page->deferred_list
>> mm/huge_memory.c: add missing read-only THP checking in
>> transparent_hugepage_enabled()
>> mm/huge_memory.c: remove unnecessary tlb_remove_page_size() for huge
>> zero pmd
>> mm/huge_memory.c: don't discard hugepage if other processes are
>> mapping it
>
> I guess it might be just better to split the series into cleans-ups
> without functional change and then fixes separately.
Sounds reasonable. But IMO all of these changes are pretty simple and independent,
maybe it's ok to keep these together?
Many thanks for comment.
> .
>
prev parent reply other threads:[~2021-04-28 8:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 13:32 [PATCH 0/5] Cleanup and fixup for huge_memory Miaohe Lin
2021-04-27 13:32 ` [PATCH 1/5] mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK Miaohe Lin
2021-04-27 20:57 ` Yang Shi
2021-04-28 3:04 ` Anshuman Khandual
2021-04-27 13:32 ` [PATCH 2/5] mm/huge_memory.c: use page->deferred_list Miaohe Lin
2021-04-27 20:46 ` Yang Shi
2021-04-28 3:07 ` Anshuman Khandual
2021-04-28 8:23 ` Miaohe Lin
2021-04-27 13:32 ` [PATCH 3/5] mm/huge_memory.c: add missing read-only THP checking in transparent_hugepage_enabled() Miaohe Lin
2021-04-27 21:03 ` Yang Shi
2021-04-28 2:06 ` Miaohe Lin
2021-04-28 16:21 ` Yang Shi
2021-04-29 2:00 ` Miaohe Lin
2021-04-27 13:32 ` [PATCH 4/5] mm/huge_memory.c: remove unnecessary tlb_remove_page_size() for huge zero pmd Miaohe Lin
2021-04-27 13:32 ` [PATCH 5/5] mm/huge_memory.c: don't discard hugepage if other processes are mapping it Miaohe Lin
2021-04-27 21:22 ` Yang Shi
2021-04-28 3:10 ` [PATCH 0/5] Cleanup and fixup for huge_memory Anshuman Khandual
2021-04-28 8:32 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e851c9-9754-dd2a-c7a4-37bbefca704a@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rcampbell@nvidia.com \
--cc=riel@surriel.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).