From: Casey Schaufler <casey@schaufler-ca.com>
To: Jiang Wang <jiang.wang@bytedance.com>,
Andrii Nakryiko <andrii@kernel.org>,
Jakub Sitnicki <jakub@cloudflare.com>,
John Fastabend <john.fastabend@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Security Module list
<linux-security-module@vger.kernel.org>
Cc: Casey Schaufler <casey@schaufler-ca.com>
Subject: Regression in unix stream sockets with the Smack LSM
Date: Mon, 13 Sep 2021 15:50:55 -0700 [thread overview]
Message-ID: <a507efa7-066b-decf-8605-89cdb0ac1951@schaufler-ca.com> (raw)
In-Reply-To: a507efa7-066b-decf-8605-89cdb0ac1951.ref@schaufler-ca.com
Commit 77462de14a43f4d98dbd8de0f5743a4e02450b1d
af_unix: Add read_sock for stream socket types
introduced a regression in UDS socket connections for the Smack LSM.
I have not tracked done the details of why the change broke the code,
but this is where bisecting the kernel indicates the problem lies, and
I have verified that reverting this change repairs the problem.
You can verify the problem with the Smack test suite:
https://github.com/smack-team/smack-testsuite.git
The failing test is tests/uds-access.sh.
I have not looked to see if there's a similar problem with SELinux.
There may be, but if there isn't it doesn't matter, there's still a
bug.
Thank you.
next parent reply other threads:[~2021-09-13 22:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a507efa7-066b-decf-8605-89cdb0ac1951.ref@schaufler-ca.com>
2021-09-13 22:50 ` Casey Schaufler [this message]
2021-09-13 23:47 ` Regression in unix stream sockets with the Smack LSM Paul Moore
2021-09-14 0:16 ` Casey Schaufler
2021-09-14 22:14 ` Casey Schaufler
2021-09-15 16:51 ` Casey Schaufler
2021-09-15 17:29 ` Jiang Wang .
2021-09-20 22:35 ` Jiang Wang .
2021-09-20 23:44 ` Casey Schaufler
2021-09-29 15:43 ` Casey Schaufler
2021-09-29 18:36 ` [External] " Jiang Wang .
2021-09-29 20:12 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a507efa7-066b-decf-8605-89cdb0ac1951@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=andrii@kernel.org \
--cc=jakub@cloudflare.com \
--cc=jiang.wang@bytedance.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).