From: James Tai <james.tai@realtek.com>
To: "Andreas Färber" <afaerber@suse.de>,
"linux-realtek-soc@lists.infradead.org"
<linux-realtek-soc@lists.infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/7] arm64: dts: realtek: rtd129x: Use reserved-memory for RPC regions
Date: Mon, 2 Dec 2019 09:49:56 +0000 [thread overview]
Message-ID: <a511b94a991946a1b3f26dcdc485d4fa@realtek.com> (raw)
In-Reply-To: <1f25f2fc-5d31-1d74-b730-78ad7861ffce@suse.de>
Hi Andreas,
> > /memreserve/ 0x0000000000000000 0x0000000000030000;
> > -/memreserve/ 0x000000000001f000 0x0000000000001000;
> > /memreserve/ 0x0000000000030000 0x00000000000d0000;
> > /memreserve/ 0x0000000001b00000 0x00000000004be000;
> > -/memreserve/ 0x0000000001ffe000 0x0000000000004000;
> >
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/reset/realtek,rtd1295.h>
> > @@ -19,6 +17,25 @@
> > #address-cells = <1>;
> > #size-cells = <1>;
> >
> > + reserved-memory {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
> > +
> > + rpc_comm: rpc@1f000 {
> > + reg = <0x1f000 0x1000>;
> > + };
> > +
> > + rpc_ringbuf: rpc@1ffe000 {
> > + reg = <0x1ffe000 0x4000>;
> > + };
>
> Have you reviewed this patch to be correct? I.e., are the above two regions
> reserved RAM (assumption above), or is this rather MMIO shadowing RAM?
> (then we would need to update the /memory reg and /soc ranges properties)
>
> That also affects RTD1619, which currently has neither.
>
The RPC common buffer and RPC ring buffer address is correct.
Regards,
James
next prev parent reply other threads:[~2019-12-02 9:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 3:04 [PATCH 0/7] arm64: dts: Initial RTD1395 and BPi-M4 support Andreas Färber
2019-11-11 3:04 ` [PATCH 1/7] arm64: dts: realtek: rtd129x: Fix GIC CPU masks for RTD1293 Andreas Färber
2019-11-11 3:04 ` [PATCH 2/7] arm64: dts: realtek: rtd129x: Use reserved-memory for RPC regions Andreas Färber
2019-12-02 8:15 ` Andreas Färber
2019-12-02 9:49 ` James Tai [this message]
2019-11-11 3:04 ` [PATCH 3/7] arm64: dts: realtek: rtd129x: Introduce r-bus Andreas Färber
2019-11-13 2:42 ` James Tai
2019-11-13 3:02 ` James Tai
2019-11-14 23:23 ` Andreas Färber
2019-11-11 3:04 ` [PATCH 4/7] ARM: dts: rtd1195: Fix GIC CPU mask Andreas Färber
2019-11-11 3:04 ` [PATCH 5/7] ARM: dts: rtd1195: Introduce r-bus Andreas Färber
2019-11-13 2:53 ` James Tai
2019-11-15 0:16 ` Andreas Färber
2019-11-18 6:53 ` James Tai
2019-11-19 11:15 ` Andreas Färber
2019-11-20 9:20 ` James Tai
2019-11-15 1:34 ` Rob Herring
2019-11-15 1:51 ` Andreas Färber
2019-11-11 3:04 ` [PATCH 6/7] dt-bindings: arm: realtek: Add RTD1395 and Banana Pi BPI-M4 Andreas Färber
2019-11-14 19:14 ` Rob Herring
2019-11-11 3:04 ` [PATCH 7/7] arm64: dts: realtek: Add RTD1395 and BPi-M4 Andreas Färber
2019-11-13 2:57 ` James Tai
2019-11-15 1:17 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a511b94a991946a1b3f26dcdc485d4fa@realtek.com \
--to=james.tai@realtek.com \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).