From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DDA7C4363D for ; Thu, 24 Sep 2020 22:23:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFC3722211 for ; Thu, 24 Sep 2020 22:23:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726650AbgIXWXn (ORCPT ); Thu, 24 Sep 2020 18:23:43 -0400 Received: from smtprelay0172.hostedemail.com ([216.40.44.172]:45502 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726280AbgIXWXn (ORCPT ); Thu, 24 Sep 2020 18:23:43 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 67C1118224D82; Thu, 24 Sep 2020 22:23:42 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: space69_45180fb27162 X-Filterd-Recvd-Size: 3682 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Thu, 24 Sep 2020 22:23:40 +0000 (UTC) Message-ID: Subject: Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon) From: Joe Perches To: Thomas Gleixner , Julia Lawall Cc: Valdis =?UTF-8?Q?Kl=C4=93tnieks?= , kernel-janitors , kernelnewbies , linux-kernel-mentees@lists.linuxfoundation.org, Andrew Morton , cocci , Giuseppe Scrivano , LKML , Andy Whitcroft Date: Thu, 24 Sep 2020 15:23:39 -0700 In-Reply-To: <87r1qqvo2d.fsf@nanos.tec.linutronix.de> References: <87r1qqvo2d.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-09-24 at 23:53 +0200, Thomas Gleixner wrote: > On Thu, Sep 24 2020 at 13:33, Joe Perches wrote: > > On Thu, 2020-09-24 at 22:19 +0200, Thomas Gleixner wrote: > > > On Sat, Aug 22 2020 at 09:07, Julia Lawall wrote: > > > > On Fri, 21 Aug 2020, Joe Perches wrote: > > > > > True enough for a general statement, though the coccinelle > > > > > script Julia provided does not change a single instance of > > > > > for loop expressions with commas. > > > > > > > > > > As far as I can tell, no logic defect is introduced by the > > > > > script at all. > > > > > > > > The script has a rule to ensure that what is changed is part of a top > > > > level statement that has the form e1, e2;. I put that in to avoid > > > > transforming cases where the comma is the body of a macro, but it protects > > > > against for loop headers as well. > > > > > > Right. I went through the lot and did not find something dodgy. Except > > > for two hunks this still applies. Can someone please send a proper patch > > > with changelog/SOB etc. for this? > > > > Treewide? > > > > Somebody no doubt would complain, but there > > _really should_ be some mechanism for these > > trivial and correct treewide changes... > > There are lots of mechanisms: I've tried them all. None of them work particularly well, especially the individual patch route. > - Andrew picks such changes up Generally not treewide. > - With a few competent eyeballs on it (reviewers) this can go thorugh > the trivial tree as well. It's more than obvious after all. Jiri is almost non-existent when it comes to trivial treewide patches. > - Send the script to Linus with a proper change log attached and ask > him to run it. Linus has concerns about backports and what he deems trivialities. Generally overblown IMO. > - In the worst case if nobody feels responsible, I'll take care. If Julia doesn't send a new patch in the next few days, I will do the apply, fixup and resend of hers. So, you're on-deck, nearly up... > All of the above is better than trying to get the attention of a > gazillion of maintainters. True. And all of the treewide changes depend on some generic acceptance of value in the type of change. Some believe that comma->semicolon conversions aren't useful as there isn't a logical change and the compiler output wouldn't be different. Anyway, cheers, Joe