From: Hans de Goede <hdegoede@redhat.com>
To: kernel test robot <lkp@intel.com>, Matan Ziv-Av <matan@svgalib.org>
Cc: kbuild-all@lists.01.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [pdx86-platform-drivers-x86:review-hans 40/40] ERROR: modpost: "battery_hook_register" [drivers/platform/x86/lg-laptop.ko] undefined!
Date: Wed, 23 Feb 2022 11:35:35 +0100 [thread overview]
Message-ID: <a5346dfb-2943-ac02-5dc3-59ab25eae17a@redhat.com> (raw)
In-Reply-To: <202202231609.ZQpgFUIn-lkp@intel.com>
Hi,
On 2/23/22 09:44, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
> head: 7e45710a8a56896d7af5c5ff4ed7cfb18573791b
> commit: 7e45710a8a56896d7af5c5ff4ed7cfb18573791b [40/40] lg-laptop: Move setting of battery charge limit to common location
> config: x86_64-randconfig-r035-20220221 (https://download.01.org/0day-ci/archive/20220223/202202231609.ZQpgFUIn-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=7e45710a8a56896d7af5c5ff4ed7cfb18573791b
> git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
> git fetch --no-tags pdx86-platform-drivers-x86 review-hans
> git checkout 7e45710a8a56896d7af5c5ff4ed7cfb18573791b
> # save the config file to linux build tree
> mkdir build_dir
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
>>> ERROR: modpost: "battery_hook_register" [drivers/platform/x86/lg-laptop.ko] undefined!
>>> ERROR: modpost: "battery_hook_unregister" [drivers/platform/x86/lg-laptop.ko] undefined!
Ah yes, config LG_LAPTOP needs a depends on ACPI_BATTERY now.
I've squashed a fix for this into the original commit in my review-hans branch.
Regards,
Hans
prev parent reply other threads:[~2022-02-23 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 8:44 [pdx86-platform-drivers-x86:review-hans 40/40] ERROR: modpost: "battery_hook_register" [drivers/platform/x86/lg-laptop.ko] undefined! kernel test robot
2022-02-23 10:35 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5346dfb-2943-ac02-5dc3-59ab25eae17a@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=matan@svgalib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).