* [PATCH platform 0/2] platform/x86: mlx-platform: Fix item counter assignment
@ 2020-12-07 17:47 Vadim Pasternak
2020-12-07 17:47 ` [PATCH platform 1/2] platform/x86: mlx-platform: Fix item counter assignment for MSN2700, MSN24xx systems Vadim Pasternak
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vadim Pasternak @ 2020-12-07 17:47 UTC (permalink / raw)
To: andy, hdegoede; +Cc: platform-driver-x86, linux-kernel, Vadim Pasternak
Fix array names to match assignments for data items and data items
counter for power and fan attributes.
Patch #1: Provide fixes for system types MSN2700, MSN24xx.
Patch #1: Provide fixes for system type MSN2700/ComEx.
Vadim Pasternak (2):
platform/x86: mlx-platform: Fix item counter assignment for MSN2700,
MSN24xx systems
platform/x86: mlx-platform: Fix item counter assignment for
MSN2700/ComEx system
drivers/platform/x86/mlx-platform.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH platform 1/2] platform/x86: mlx-platform: Fix item counter assignment for MSN2700, MSN24xx systems
2020-12-07 17:47 [PATCH platform 0/2] platform/x86: mlx-platform: Fix item counter assignment Vadim Pasternak
@ 2020-12-07 17:47 ` Vadim Pasternak
2020-12-07 17:47 ` [PATCH platform 2/2] platform/x86: mlx-platform: Fix item counter assignment for MSN2700/ComEx system Vadim Pasternak
2020-12-08 10:17 ` [PATCH platform 0/2] platform/x86: mlx-platform: Fix item counter assignment Hans de Goede
2 siblings, 0 replies; 4+ messages in thread
From: Vadim Pasternak @ 2020-12-07 17:47 UTC (permalink / raw)
To: andy, hdegoede; +Cc: platform-driver-x86, linux-kernel, Vadim Pasternak
Fix array names to match assignments for data items and data items
counter in 'mlxplat_mlxcpld_default_items' structure for:
.data = mlxplat_mlxcpld_default_pwr_items_data,
.count = ARRAY_SIZE(mlxplat_mlxcpld_pwr),
and
.data = mlxplat_mlxcpld_default_fan_items_data,
.count = ARRAY_SIZE(mlxplat_mlxcpld_fan),
Replace:
- 'mlxplat_mlxcpld_pwr' by 'mlxplat_mlxcpld_default_pwr_items_data' for
ARRAY_SIZE() calculation.
- 'mlxplat_mlxcpld_fan' by 'mlxplat_mlxcpld_default_fan_items_data'
for ARRAY_SIZE() calculation.
Fixes: c6acad68eb2d ("platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
drivers/platform/x86/mlx-platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 6a634b72bfc2..b30ebd17f3de 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -456,7 +456,7 @@ static struct mlxreg_core_item mlxplat_mlxcpld_default_items[] = {
.aggr_mask = MLXPLAT_CPLD_AGGR_PWR_MASK_DEF,
.reg = MLXPLAT_CPLD_LPC_REG_PWR_OFFSET,
.mask = MLXPLAT_CPLD_PWR_MASK,
- .count = ARRAY_SIZE(mlxplat_mlxcpld_pwr),
+ .count = ARRAY_SIZE(mlxplat_mlxcpld_default_pwr_items_data),
.inversed = 0,
.health = false,
},
@@ -465,7 +465,7 @@ static struct mlxreg_core_item mlxplat_mlxcpld_default_items[] = {
.aggr_mask = MLXPLAT_CPLD_AGGR_FAN_MASK_DEF,
.reg = MLXPLAT_CPLD_LPC_REG_FAN_OFFSET,
.mask = MLXPLAT_CPLD_FAN_MASK,
- .count = ARRAY_SIZE(mlxplat_mlxcpld_fan),
+ .count = ARRAY_SIZE(mlxplat_mlxcpld_default_fan_items_data),
.inversed = 1,
.health = false,
},
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH platform 2/2] platform/x86: mlx-platform: Fix item counter assignment for MSN2700/ComEx system
2020-12-07 17:47 [PATCH platform 0/2] platform/x86: mlx-platform: Fix item counter assignment Vadim Pasternak
2020-12-07 17:47 ` [PATCH platform 1/2] platform/x86: mlx-platform: Fix item counter assignment for MSN2700, MSN24xx systems Vadim Pasternak
@ 2020-12-07 17:47 ` Vadim Pasternak
2020-12-08 10:17 ` [PATCH platform 0/2] platform/x86: mlx-platform: Fix item counter assignment Hans de Goede
2 siblings, 0 replies; 4+ messages in thread
From: Vadim Pasternak @ 2020-12-07 17:47 UTC (permalink / raw)
To: andy, hdegoede; +Cc: platform-driver-x86, linux-kernel, Vadim Pasternak
Fix array names to match assignments for data items and data items
counter in 'mlxplat_mlxcpld_comex_items' structure for:
.data = mlxplat_mlxcpld_default_pwr_items_data,
.count = ARRAY_SIZE(mlxplat_mlxcpld_pwr),
and
.data = mlxplat_mlxcpld_default_fan_items_data,
.count = ARRAY_SIZE(mlxplat_mlxcpld_fan),
Replace:
- 'mlxplat_mlxcpld_pwr' by 'mlxplat_mlxcpld_default_pwr_items_data' for
ARRAY_SIZE() calculation.
- 'mlxplat_mlxcpld_fan' by 'mlxplat_mlxcpld_default_fan_items_data'
for ARRAY_SIZE() calculation.
Fixes: bdd6e155e0d6 ("platform/x86: mlx-platform: Add support for new system type")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
drivers/platform/x86/mlx-platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index b30ebd17f3de..8bce3da32a42 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -495,7 +495,7 @@ static struct mlxreg_core_item mlxplat_mlxcpld_comex_items[] = {
.aggr_mask = MLXPLAT_CPLD_AGGR_MASK_CARRIER,
.reg = MLXPLAT_CPLD_LPC_REG_PWR_OFFSET,
.mask = MLXPLAT_CPLD_PWR_MASK,
- .count = ARRAY_SIZE(mlxplat_mlxcpld_pwr),
+ .count = ARRAY_SIZE(mlxplat_mlxcpld_default_pwr_items_data),
.inversed = 0,
.health = false,
},
@@ -504,7 +504,7 @@ static struct mlxreg_core_item mlxplat_mlxcpld_comex_items[] = {
.aggr_mask = MLXPLAT_CPLD_AGGR_MASK_CARRIER,
.reg = MLXPLAT_CPLD_LPC_REG_FAN_OFFSET,
.mask = MLXPLAT_CPLD_FAN_MASK,
- .count = ARRAY_SIZE(mlxplat_mlxcpld_fan),
+ .count = ARRAY_SIZE(mlxplat_mlxcpld_default_fan_items_data),
.inversed = 1,
.health = false,
},
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH platform 0/2] platform/x86: mlx-platform: Fix item counter assignment
2020-12-07 17:47 [PATCH platform 0/2] platform/x86: mlx-platform: Fix item counter assignment Vadim Pasternak
2020-12-07 17:47 ` [PATCH platform 1/2] platform/x86: mlx-platform: Fix item counter assignment for MSN2700, MSN24xx systems Vadim Pasternak
2020-12-07 17:47 ` [PATCH platform 2/2] platform/x86: mlx-platform: Fix item counter assignment for MSN2700/ComEx system Vadim Pasternak
@ 2020-12-08 10:17 ` Hans de Goede
2 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2020-12-08 10:17 UTC (permalink / raw)
To: Vadim Pasternak, andy; +Cc: platform-driver-x86, linux-kernel
Hi,
On 12/7/20 6:47 PM, Vadim Pasternak wrote:
> Fix array names to match assignments for data items and data items
> counter for power and fan attributes.
>
> Patch #1: Provide fixes for system types MSN2700, MSN24xx.
> Patch #1: Provide fixes for system type MSN2700/ComEx.
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
>
> Vadim Pasternak (2):
> platform/x86: mlx-platform: Fix item counter assignment for MSN2700,
> MSN24xx systems
> platform/x86: mlx-platform: Fix item counter assignment for
> MSN2700/ComEx system
>
> drivers/platform/x86/mlx-platform.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-08 10:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 17:47 [PATCH platform 0/2] platform/x86: mlx-platform: Fix item counter assignment Vadim Pasternak
2020-12-07 17:47 ` [PATCH platform 1/2] platform/x86: mlx-platform: Fix item counter assignment for MSN2700, MSN24xx systems Vadim Pasternak
2020-12-07 17:47 ` [PATCH platform 2/2] platform/x86: mlx-platform: Fix item counter assignment for MSN2700/ComEx system Vadim Pasternak
2020-12-08 10:17 ` [PATCH platform 0/2] platform/x86: mlx-platform: Fix item counter assignment Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).