From: Boaz Harrosh <ooo@electrozaur.com>
To: Fabian Frederick <fabf@skynet.be>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/11 linux-next] exofs: use magic.h
Date: Tue, 23 May 2017 11:06:33 +0300 [thread overview]
Message-ID: <a55d1404-3ad8-cd25-8686-5739a793d2db@electrozaur.com> (raw)
In-Reply-To: <20170521154031.26761-1-fabf@skynet.be>
On 05/21/2017 06:40 PM, Fabian Frederick wrote:
> Filesystems generally use SUPER_MAGIC values from magic.h
> instead of a local definition.
>
Is fine by me to move to magic.h but ...
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/exofs/common.h | 6 +-----
> include/uapi/linux/magic.h | 1 +
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/exofs/common.h b/fs/exofs/common.h
> index 7d88ef5..fb988f9 100644
> --- a/fs/exofs/common.h
> +++ b/fs/exofs/common.h
> @@ -37,6 +37,7 @@
> #define __EXOFS_COM_H__
>
> #include <linux/types.h>
> +#include <linux/magic.h>
>
> #include <scsi/osd_attributes.h>
> #include <scsi/osd_initiator.h>
> @@ -79,11 +80,6 @@ enum {
> #define EXOFS_BLKSHIFT 12
> #define EXOFS_BLKSIZE (1UL << EXOFS_BLKSHIFT)
>
> -/****************************************************************************
> - * superblock-related things
> - ****************************************************************************/
Please do not remove this comment, it acts as a separator and is related to
everything up to the comment that says:
* inode-related things
And not only to this definition
Thanks
Boaz
> -#define EXOFS_SUPER_MAGIC 0x5DF5
> -
> /*
> * The file system control block - stored in object EXOFS_SUPER_ID's data.
> * This is where the in-memory superblock is stored on disk.
> diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h
> index e3bb43b..1265355 100644
> --- a/include/uapi/linux/magic.h
> +++ b/include/uapi/linux/magic.h
> @@ -26,6 +26,7 @@
> #define EXT2_SUPER_MAGIC 0xEF53
> #define EXT3_SUPER_MAGIC 0xEF53
> #define EXT4_SUPER_MAGIC 0xEF53
> +#define EXOFS_SUPER_MAGIC 0x5DF5
> #define F2FS_SUPER_MAGIC 0xF2F52010
> #define FUTEXFS_SUPER_MAGIC 0xBAD1DEA
> #define HOSTFS_SUPER_MAGIC 0x00c0ffee
>
prev parent reply other threads:[~2017-05-23 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 15:40 [PATCH 02/11 linux-next] exofs: use magic.h Fabian Frederick
2017-05-23 8:06 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a55d1404-3ad8-cd25-8686-5739a793d2db@electrozaur.com \
--to=ooo@electrozaur.com \
--cc=fabf@skynet.be \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).