From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Aubrey Li <aubrey.li@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: New warning: PRMT not present (was: not found)
Date: Tue, 7 Sep 2021 09:22:33 +0200 [thread overview]
Message-ID: <a55ebebc-c8f8-5654-adff-3569d1de2e27@molgen.mpg.de> (raw)
In-Reply-To: <54b6f8cb-4714-587c-b2d0-98134473293d@linux.intel.com>
Dear Aubrey,
Thank you very much for quick reply.
Am 07.09.21 um 05:26 schrieb Aubrey Li:
> On 9/6/21 10:15 PM, Paul Menzel wrote:
>> Am 06.09.21 um 14:02 schrieb Rafael J. Wysocki:
>>>
>>> This should be addressed by commit 2bbfa0addd63 "ACPI: PRM: Deal with
>>> table not present or no module found", or yet another fix is needed.
>>
>> Linux still warns on my systems with Linux 5.14 and Linus’ master in QEMU i440fx and an Asus F2A85-M PRO.
>
> Does the following patch address your problem?
Yes, it does. With this patch cherry-picked to my Linux tree, the
warning is gone in QEMU.
qemu-system-x86_64 -kernel /dev/shm/bzImage -append
"earlyprintk=serial,ttyS0,keep console=ttyS0,115200 console=tty0"
-display none -serial stdio
(I have to check my configuration, why normal serial console does not
work in QEMU.)
> ----------------------------------------------------------------------
> From 52fda76410fcb7a3661687e960634d34fa44fb5f Mon Sep 17 00:00:00 2001
> From: Aubrey Li <aubrey.li@intel.com>
> Date: Tue, 7 Sep 2021 11:06:59 +0800
> Subject: [PATCH] ACPI/RPM: Find PRMT table before parse it
What does RPM mean?
> Find and verify PRMT table before parse it, this eliminates a
> warning on machines without PRMT table.
Please paste the warning for people grepping the commit messages.
ACPI: PRMT not present
> Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
> ---
> drivers/acpi/prmt.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/prmt.c b/drivers/acpi/prmt.c
> index 1f6007a..89c22bc 100644
> --- a/drivers/acpi/prmt.c
> +++ b/drivers/acpi/prmt.c
> @@ -288,10 +288,18 @@ static acpi_status acpi_platformrt_space_handler(u32 function,
>
> void __init init_prmt(void)
> {
> + struct acpi_table_header *tbl;
> acpi_status status;
> - int mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
> + int mc;
> +
> + status = acpi_get_table(ACPI_SIG_PRMT, 0, &tbl);
> + if (ACPI_FAILURE(status))
> + return;
> +
> + mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
> sizeof (struct acpi_table_prmt_header),
> 0, acpi_parse_prmt, 0);
> + acpi_put_table(tbl);
> /*
> * Return immediately if PRMT table is not present or no PRM module found.
> */
>
Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
next prev parent reply other threads:[~2021-09-07 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 7:42 New warning: PRMT not found Paul Menzel
2021-09-06 11:51 ` Paul Menzel
2021-09-06 12:02 ` Rafael J. Wysocki
2021-09-06 14:15 ` Paul Menzel
2021-09-07 3:26 ` Aubrey Li
2021-09-07 7:22 ` Paul Menzel [this message]
2021-09-07 13:02 ` New warning: PRMT not present Aubrey Li
2021-09-07 13:23 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a55ebebc-c8f8-5654-adff-3569d1de2e27@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=aubrey.li@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).