From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 562F2C43460 for ; Thu, 8 Apr 2021 16:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31A6A61104 for ; Thu, 8 Apr 2021 16:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232241AbhDHQa2 (ORCPT ); Thu, 8 Apr 2021 12:30:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26946 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231480AbhDHQaZ (ORCPT ); Thu, 8 Apr 2021 12:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617899413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O4lfbTcUn40NhH6SPLDopboHGBG7ClEKdMUOAOGm9X8=; b=gmpl9r5fP6KDON19H1eOB32TXMg8VGifHY50XqNX1YAqhF4zUNyxV/rTgCSEvbWhBaIoj9 I43ANVPi898YjO1VW0aoR1lkBQjscc53jPQjbp6RNbB8ntdgRUrwJVkMOKuz5BSNltYLHo hD2Z+PX0pVZH2jmDw7q7M6AgPb6x/HQ= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-67Xrb3LUNQWn5raheY3g_A-1; Thu, 08 Apr 2021 12:30:12 -0400 X-MC-Unique: 67Xrb3LUNQWn5raheY3g_A-1 Received: by mail-ed1-f71.google.com with SMTP id dj13so1285696edb.14 for ; Thu, 08 Apr 2021 09:30:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O4lfbTcUn40NhH6SPLDopboHGBG7ClEKdMUOAOGm9X8=; b=FewGeHNu+oLrvqNdkNR+PBRGXvpzknqmRdlGKkVGDDlAFiYdqhupvekRtWSXsImDPl feOtIIISjjGER9USxNiRyCZ0Oktj669tiPOaDOxrH3VOJvVl1MXWjFqZ6uvnEBhm2smy ISSThxfF2IHLgDAIpB0DO7piOeSf0jlrUb9frFU6gBBSpnHiSvAufkbBNr0QKijDiA1+ sZRbNmOTWfHN9XKTzyBWqLeY4bQKXFEE4pSb66Gk29KKsoCe3pHZm2BDaiNeLH7TmwjM tBKpsVP7Z1bw0W0atSojWeZIU9mQiG4jK4o1eRz5stDbRV5bVN2z6M0q8QAecv6VnPgg t7iQ== X-Gm-Message-State: AOAM530qFjNnowygYCHLlbW1medDGiNHUioaKeWZ0vcc/GV7V519JMId zmw2+wmbEPRq4CT2WLR2y3BSNqEzmkExo52AUY756m8P+Jx9LyGU49YhLmcCybfF0vK53lxpNYO zTecnP32P+6advCTjLtXi9p00 X-Received: by 2002:aa7:c351:: with SMTP id j17mr9839701edr.199.1617899411099; Thu, 08 Apr 2021 09:30:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTDwqV/P6EhYvUAHlyr3YimJfoVAFKZLgaFq2or2LlrGXaxuLi7ZwvU1MKde2NCQ9NRw/hzA== X-Received: by 2002:aa7:c351:: with SMTP id j17mr9839673edr.199.1617899410915; Thu, 08 Apr 2021 09:30:10 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id bx19sm1801808ejc.53.2021.04.08.09.30.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 09:30:10 -0700 (PDT) Subject: Re: [PATCH v2 07/17] KVM: x86/mmu: Check PDPTRs before allocating PAE roots To: Sean Christopherson Cc: Wanpeng Li , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm , LKML , Ben Gardon , Brijesh Singh , Tom Lendacky References: <20210305011101.3597423-1-seanjc@google.com> <20210305011101.3597423-8-seanjc@google.com> <8b7129ed-0377-7b91-c741-44ac2202081a@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 8 Apr 2021 18:30:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/04/21 18:27, Sean Christopherson wrote: > For your approach, can we put the out label after the success path? Setting > mmu->root_pgd isn't wrong per se, but doing so might mislead future readers into > thinking that it's functionally necessary. Indeed, thanks for the speedy review. I'll get it queued tomorrow. Paolo