From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65C20C2D0D2 for ; Fri, 20 Dec 2019 11:23:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B7BA2465E for ; Fri, 20 Dec 2019 11:23:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="vWBCHnhE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbfLTLXa (ORCPT ); Fri, 20 Dec 2019 06:23:30 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:40354 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727184AbfLTLXa (ORCPT ); Fri, 20 Dec 2019 06:23:30 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id xBKBNRdx078554; Fri, 20 Dec 2019 05:23:27 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1576841007; bh=GGo0UqaDWF2C26AMO3J7zsJZNuO5lIDTl3DebqtQbeQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=vWBCHnhEpoBpfH7WRmAxYNCDefdLv2Hz0z76c6W46b7za52A7K2N2Ry4q426TK2ke 1MYGFA6BGC9Eozxl8GJjk4ClXCZnAGvhXVX4umD/yL/NXuqH+h86Mx5lwnGOFqlw4z du685NcduPn9IvYRE1DJEvrxYeILR1PvqRLxhVlE= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xBKBNRef114777 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Dec 2019 05:23:27 -0600 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Fri, 20 Dec 2019 05:23:27 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Fri, 20 Dec 2019 05:23:26 -0600 Received: from [10.24.69.159] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id xBKBNOl3010044; Fri, 20 Dec 2019 05:23:25 -0600 Subject: Re: [PATCH] phy: qualcomm: Adjust indentation in read_poll_timeout To: Bjorn Andersson , Nathan Chancellor CC: Andy Gross , , , References: <20191218013637.29123-1-natechancellor@gmail.com> <20191218062906.GB3755841@builder> From: Kishon Vijay Abraham I Message-ID: Date: Fri, 20 Dec 2019 16:55:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191218062906.GB3755841@builder> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/12/19 11:59 am, Bjorn Andersson wrote: > On Tue 17 Dec 17:36 PST 2019, Nathan Chancellor wrote: > >> Clang warns: >> >> ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:83:4: warning: >> misleading indentation; statement is not part of the previous 'if' >> [-Wmisleading-indentation] >> usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50); >> ^ >> ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:80:3: note: previous >> statement is here >> if (readl_relaxed(addr) & mask) >> ^ >> 1 warning generated. >> >> This warning occurs because there is a space after the tab on this line. >> Remove it so that the indentation is consistent with the Linux kernel >> coding style and clang no longer warns. >> > > Reviewed-by: Bjorn Andersson merged, thanks! -Kishon > >> Fixes: 1de990d8a169 ("phy: qcom: Add driver for QCOM APQ8064 SATA PHY") >> Link: https://github.com/ClangBuiltLinux/linux/issues/816 >> Signed-off-by: Nathan Chancellor >> --- >> drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c b/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c >> index 42bc5150dd92..febe0aef68d4 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c >> +++ b/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c >> @@ -80,7 +80,7 @@ static int read_poll_timeout(void __iomem *addr, u32 mask) >> if (readl_relaxed(addr) & mask) >> return 0; >> >> - usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50); >> + usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50); >> } while (!time_after(jiffies, timeout)); >> >> return (readl_relaxed(addr) & mask) ? 0 : -ETIMEDOUT; >> -- >> 2.24.1 >>