From: Ping-Ke Shih <pkshih@realtek.com>
To: Breno Leitao <leitao@debian.org>, Kalle Valo <kvalo@kernel.org>
Cc: "leit@meta.com" <leit@meta.com>,
"open list:REALTEK WIRELESS DRIVER (rtw88)"
<linux-wireless@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH wireless-next] wifi: rtw88: Un-embed dummy device
Date: Fri, 26 Apr 2024 00:14:22 +0000 [thread overview]
Message-ID: <a581c6216456468e8695af38c985973d@realtek.com> (raw)
In-Reply-To: <20240425082910.2824393-1-leitao@debian.org>
Breno Leitao <leitao@debian.org> wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
>
> Un-embed the net_device from the private struct by converting it
> into a pointer. Then use the leverage the new alloc_netdev_dummy()
> helper to allocate and initialize dummy devices.
>
> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Like patch of rtw89, I will take it to my tree weeks later.
> ---
> drivers/net/wireless/realtek/rtw88/pci.c | 17 +++++++++++++----
> drivers/net/wireless/realtek/rtw88/pci.h | 2 +-
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
> PS: This is compile-tested only due to lack of hardware to do better
> testing.
Tested with real hardware RTL8723DE and RTL8822CE.
Tested-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2024-04-26 0:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 8:29 [PATCH wireless-next] wifi: rtw88: Un-embed dummy device Breno Leitao
2024-04-26 0:14 ` Ping-Ke Shih [this message]
2024-05-09 6:18 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a581c6216456468e8695af38c985973d@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@kernel.org \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).