From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757446AbcLUHeK (ORCPT ); Wed, 21 Dec 2016 02:34:10 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36493 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755526AbcLUHeF (ORCPT ); Wed, 21 Dec 2016 02:34:05 -0500 Subject: Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f To: John Crispin , Cyrille Pitchen References: <1482304990-23942-1-git-send-email-john@phrozen.org> <1482304990-23942-3-git-send-email-john@phrozen.org> Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Andr=c3=a9_Valentin?= From: Marek Vasut Message-ID: Date: Wed, 21 Dec 2016 08:33:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1482304990-23942-3-git-send-email-john@phrozen.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/2016 08:23 AM, John Crispin wrote: > From: André Valentin > > This patch adds support for a new macronix spi flash chip. We have had this > patch inside our tree for a while and people are actively using routers > with this chip. > > Signed-off-by: John Crispin > Signed-off-by: André Valentin > --- > Changes in V2 > * add description > * add SECT_4K > * fix indenting Are you SURE this chip can do sect_4k ? The datasheet seems to imply that, but I wonder why it wasn't in V1 of this patch then ? Esp. if people are actively using this chip ... > drivers/mtd/spi-nor/spi-nor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 171adb3..bfff159 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -868,6 +868,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len) > { "mx25l3205d", INFO(0xc22016, 0, 64 * 1024, 64, SECT_4K) }, > { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) }, > { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) }, > + { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64, SECT_4K) }, > { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) }, > { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) }, > { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) }, > -- Best regards, Marek Vasut