From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbdHADIZ (ORCPT ); Mon, 31 Jul 2017 23:08:25 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:38567 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbdHADIX (ORCPT ); Mon, 31 Jul 2017 23:08:23 -0400 Subject: Re: [PATCH] iio: accel: Bugfix to enbale and allow different events to work parallely. From: Harinath Nampally To: Martin Kepplinger Cc: Jonathan Cameron , knaack.h@gmx.de, lars@metafoo.de, Peter Meerwald-Stadler , Greg KH , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Alison Schofield References: <1501499858-4476-1-git-send-email-harinath922@gmail.com> <653B8888-D699-4B8B-93C2-6FF3308932AF@posteo.de> Message-ID: Date: Mon, 31 Jul 2017 23:08:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Thanks for doing that work. I have had it on my list for a long time and you seem to fix it. Although I'd happily review and possibly test it, unfortunately I can't do so before the week of August 21st. > > If this might go in quick, nothing will stop me from reviewing either, so, whatever. Thanks again! Sure no problem, looking forward to your review comments. Actually I am planning to add Orientation events for FXLS8471Q, for that is it good idea to overload existing IIO_ROT channel type? Also thinking of adding 4 channel modifiers i.e portrait up/down, landscape left/right. Any suggestions are welcome. Thank you. On 07/31/2017 10:17 PM, harinath Nampally wrote: >> This driver supports multiple devices like mma8653, mma8652, mma8452, >> mma8453 and >> fxls8471. Almost all these devices have more than one event. Current >> driver design >> hardcodes the event specific information, so only one event can be >> supported by this >> driver and current design doesn't have the flexibility to add more >> events. >> >> This patch fixes by detaching the event related information from >> chip_info struct, >> and based on channel type and event direction the corresponding event >> configuration registers >> are picked dynamically. Hence multiple events can be handled in >> read/write callbacks. >> >> Changes are thoroughly tested on fxls8471 device on imx6UL Eval board >> using iio_event_monitor user space program. >> >> After this fix both Freefall and Transient events are handled by the >> driver without any conflicts. > Thanks for doing that work. I have had it on my list for a long time and you seem to fix it. Although I'd happily review and possibly test it, unfortunately I can't do so before the week of August 21st. > > If this might go in quick, nothing will stop me from reviewing either, so, whatever. Thanks again!