On 6/2/21 10:18 AM, Stephen Boyd wrote: > Quoting Peng Fan (OSS) (2021-05-28 04:34:00) >> From: Peng Fan >> >> To i.MX8ULP, a PCC register provides clk(mux, gate, divider) and peripheral >> reset functionality, so we need make sure the access to the PCC register >> be protected to avoid concurrent access from clk and reset subsystem. >> >> So let's use regmap here. >> >> The i.MX specific code will be posted if this patchset is ok for you. > > We have a couple regmap clk drivers in the tree. Either combine the > different regmap clk drivers or duplicate it into the imx directory. I'd > prefer we combine them but last time I couldn't agree on the approach > when Jerome wanted to do it. Maybe now is the time to combine them all > into one common piece of code. IMHO for the basic drivers, such as gate, divider, mux, mux-div, etc... it makes no sense to have them in an arch specific subdir, like meson. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |