From: Michael Walle <michael@walle.cc>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
linuxppc-dev@lists.ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Timur Tabi <timur@kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ASoC: fsl_sai: add IRQF_SHARED
Date: Thu, 05 Dec 2019 10:18:10 +0100 [thread overview]
Message-ID: <a5accae02f840f7e25099c2ccd7b02ff@walle.cc> (raw)
In-Reply-To: <CAEnQRZCnQAUVowOJw5aPe9rYWU5DKR4bFbmQLYV2BzYqOhRJmQ@mail.gmail.com>
Hi Daniel,
Am 2019-12-05 09:43, schrieb Daniel Baluta:
> On Fri, Nov 29, 2019 at 12:40 AM Michael Walle <michael@walle.cc>
> wrote:
>>
>> The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use
>> IRQF_SHARED to be able to use these SAIs simultaneously.
>
> Hi Michael,
>
> Thanks for the patch. We have a similar change inside our internal tree
> (it is on my long TODO list to upstream :D).
>
> We add the shared flag conditionally on a dts property.
>
> Do you think it is a good idea to always add shared flag? I'm thinking
> on SAI IP integrations where the interrupt is edge triggered.
Mhh, I don't really get the point to make the flag conditionally. If
there is only one user, the flag won't hurt, correct?
If there are two users, we need the flag anyway.
> AFAIK edge triggered interrupts do not get along very well
> with sharing an interrupt line.
So in that case you shouldn't use shared edge triggered interrupts in
the
SoC in the first place, I guess.
-michael
next prev parent reply other threads:[~2019-12-05 9:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 22:38 [PATCH] ASoC: fsl_sai: add IRQF_SHARED Michael Walle
2019-11-29 21:57 ` Fabio Estevam
2019-12-05 2:17 ` Nicolin Chen
2019-12-05 8:43 ` Daniel Baluta
2019-12-05 9:18 ` Michael Walle [this message]
2019-12-05 9:45 ` Daniel Baluta
2019-12-09 18:59 ` Applied "ASoC: fsl_sai: add IRQF_SHARED" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5accae02f840f7e25099c2ccd7b02ff@walle.cc \
--to=michael@walle.cc \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).