From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Melody Olvera <quic_molvera@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Taniya Das <quic_tdas@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clocks
Date: Sun, 20 Nov 2022 12:06:55 +0100 [thread overview]
Message-ID: <a5afd699-64a5-4034-88d2-95035e08c9c7@linaro.org> (raw)
In-Reply-To: <20221118181826.28269-2-quic_molvera@quicinc.com>
On 18/11/2022 19:18, Melody Olvera wrote:
> Add device tree bindings for global clock controller on QDU1000 and
> QRU1000 SoCs.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> .../bindings/clock/qcom,gcc-qdu1000.yaml | 70 ++++++++
> include/dt-bindings/clock/qcom,gcc-qdu1000.h | 170 ++++++++++++++++++
> 2 files changed, 240 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-qdu1000.yaml
> create mode 100644 include/dt-bindings/clock/qcom,gcc-qdu1000.h
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-qdu1000.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-qdu1000.yaml
> new file mode 100644
> index 000000000000..90935a6795ee
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-qdu1000.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,gcc-qdu1000.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Global Clock & Reset Controller for QDU1000 and QRU1000
> +
> +allOf:
> + - $ref: qcom,gcc.yaml#
> +
> +maintainers:
> + - Melody Olvera <quic_molvera@quicinc.com>
> +
> +description: |
> + Qualcomm global clock control module which supports the clocks, resets and
> + power domains on QDU1000 and QRU1000
Keep the same style as existing files. They were cleaned up recently.
> +
> + See also:
> + - include/dt-bindings/clock/qcom,gcc-qdu1000.h
Keep the same style, so missing '::', drop '- '.
> +
> +properties:
> + compatible:
> + items:
> + - const: qcom,gcc-qdu1000
SM8550 is coming with proper style of compatible, so let's do the same
also here: qcom,qdu1000-gcc
(and file name matching it)
> + - const: syscon
I don't see usage of it as syscon. Which parts of GCC are needed for whom?
> +
> + clocks:
> + items:
> + - description: Board XO source
> + - description: Sleep clock source
> + - description: PCIE 0 Pipe clock source
> + - description: PCIE 0 Phy Auxiliary clock source
> + - description: USB3 Phy wrapper pipe clock source
> + minItems: 2
Same question as for SM8550 - why inputs are flexible? Either you have
these or you do not.
> +
> + '#clock-cells':
> + const: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + '#power-domain-cells':
> + const: 1
Missing ref to gcc.yaml. Drop all properties provided by gcc.yaml.
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - '#clock-cells'
> + - '#reset-cells'
Drop these required by gcc.yaml.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-20 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 18:18 [PATCH v4 0/2] clk: qcom: Add clocks for the QDU1000 and QRU1000 SoC Melody Olvera
2022-11-18 18:18 ` [PATCH v4 1/2] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clocks Melody Olvera
2022-11-20 11:06 ` Krzysztof Kozlowski [this message]
2022-11-21 20:19 ` Melody Olvera
2022-11-18 18:18 ` [PATCH v4 2/2] clk: qcom: Add QDU1000 and QRU1000 GCC support Melody Olvera
2022-11-21 11:11 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5afd699-64a5-4034-88d2-95035e08c9c7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).