From: Jan Kiszka <jan.kiszka@siemens.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
David Laight <David.Laight@aculab.com>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 6/7] gpio: exar: switch to using regmap
Date: Tue, 10 Nov 2020 15:50:11 +0100 [thread overview]
Message-ID: <a5b0fcd0-eb62-79b3-3f27-6595b9bdb91c@siemens.com> (raw)
In-Reply-To: <CAMpxmJUQ3t02q-Chd-WE+pYRAsOOEnbQ0jB+G_uAGv+sJBK1tg@mail.gmail.com>
On 10.11.20 15:30, Bartosz Golaszewski wrote:
> On Tue, Nov 10, 2020 at 3:26 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>>
>> On Tue, Nov 10, 2020 at 04:26:24PM +0200, Andy Shevchenko wrote:
>>> On Tue, Nov 10, 2020 at 01:34:05PM +0100, Bartosz Golaszewski wrote:
>>>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>>>
>>>> We can simplify the code in gpio-exar by using regmap. This allows us to
>>>> drop the mutex (regmap provides its own locking) and we can also reuse
>>>> regmap's bit operations instead of implementing our own update function.
>>>
>>> ...
>>>
>>>> + /*
>>>> + * We don't need to check the return values of mmio regmap operations (unless
>>>> + * the regmap has a clock attached which is not the case here).
>>>> + */
>>>> + exar_gpio->regs = devm_regmap_init_mmio(dev, p, &exar_regmap_config);
>>>> + if (IS_ERR(exar_gpio->regs))
>>>> + return PTR_ERR(exar_gpio->regs);
>>>>
>>>> index = ida_alloc(&ida_index, GFP_KERNEL);
>>>> - if (index < 0) {
>>>> - ret = index;
>>>> - goto err_mutex_destroy;
>>>> - }
>>>> + if (index < 0)
>>>> + return index;
>>>
>>> And below you effectively use p as regmap!
>>> That's what renaming of variable regs -> regmap or map can easily reveal.
>>>
>>> exar_gpio->regs = p;
>>
>> Jan, if you remove this line, does it help?
>>
>
> Ha! I guess you were right saying that keeping the name is asking for
> trouble then. :)
>
> I think that may be it but address width should still be changed to 16.
>
Removing the line that Andy found made things work here. And switching
to 16 for reg_bits didn't make things worse again.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2020-11-10 14:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 12:33 [PATCH v3 0/7] gpio: exar: refactor the driver Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 1/7] gpio: exar: add a newline after the copyright notice Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 2/7] gpio: exar: include idr.h Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 3/7] gpio: exar: switch to a simpler IDA interface Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 4/7] gpio: exar: use a helper variable for &pdev->dev Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 5/7] gpio: exar: unduplicate address and offset computation Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 6/7] gpio: exar: switch to using regmap Bartosz Golaszewski
2020-11-10 13:23 ` Jan Kiszka
2020-11-10 13:29 ` Bartosz Golaszewski
2020-11-10 13:51 ` Jan Kiszka
2020-11-10 14:11 ` Andy Shevchenko
2020-11-10 14:24 ` Bartosz Golaszewski
2020-11-10 14:26 ` Andy Shevchenko
2020-11-10 14:27 ` Andy Shevchenko
2020-11-10 14:30 ` Bartosz Golaszewski
2020-11-10 14:50 ` Jan Kiszka [this message]
2020-11-10 14:52 ` Bartosz Golaszewski
2020-11-10 15:01 ` Andy Shevchenko
2020-11-10 12:34 ` [PATCH v3 7/7] gpio: exar: use devm action for freeing the IDA and drop remove() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5b0fcd0-eb62-79b3-3f27-6595b9bdb91c@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=David.Laight@aculab.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).