From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
sh4nnu <manikishanghantasala@gmail.com>
Cc: Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h
Date: Wed, 02 Jun 2021 08:36:41 -0700 [thread overview]
Message-ID: <a5b5c871537bcc6931894e8f61ca7b28950c114a.camel@perches.com> (raw)
In-Reply-To: <YLehYmLYBMmI8MOk@kroah.com>
On Wed, 2021-06-02 at 17:18 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 02, 2021 at 08:40:33PM +0530, sh4nnu wrote:
> > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
> >
> > "Macros with complex values should be enclosed in parantheses"
> > by enclosing values in parantheses.
parentheses
> > Signed-off-by: sh4nnu <manikishanghantasala@gmail.com>
[]
> - It looks like you did not use your "real" name for the patch on either
> the Signed-off-by: line, or the From: line (both of which have to
> match). Please read the kernel file, Documentation/SubmittingPatches
> for how to do this correctly.
Might be useful to have the patchbot script reduce the content of the
message when it's identifiable.
The patch itself looks OK.
next prev parent reply other threads:[~2021-06-02 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 15:10 [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h sh4nnu
2021-06-02 15:18 ` Greg Kroah-Hartman
2021-06-02 15:36 ` Joe Perches [this message]
2021-06-02 15:42 ` Manikishan Ghantasala
2021-06-02 16:03 Manikishan Ghantasala
2021-06-02 17:15 ` Greg Kroah-Hartman
2021-06-02 17:34 ` Manikishan Ghantasala
2021-06-02 18:01 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5b5c871537bcc6931894e8f61ca7b28950c114a.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manikishanghantasala@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).