From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: kishon@ti.com, bjorn.andersson@linaro.org, andy.gross@linaro.org,
david.brown@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org,
gregkh@linuxfoundation.org, balbi@kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v1 4/6] phy: qcom-qmp: Add QMP V3 USB3 PHY support for msm8998
Date: Fri, 11 Jan 2019 12:48:50 -0700 [thread overview]
Message-ID: <a5f38a7b-a761-c924-08ef-fc685f027561@codeaurora.org> (raw)
In-Reply-To: <20190111194513.GA13699@bogus>
On 1/11/2019 12:45 PM, Rob Herring wrote:
> On Fri, Jan 04, 2019 at 09:50:47AM -0700, Jeffrey Hugo wrote:
>> MSM8998 contains a single QMP v3 USB3 phy similar to the existing sdm845
>> support, however MSM8998 does not have display port (DP) support.
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +
>> drivers/phy/qualcomm/phy-qcom-qmp.c | 142 +++++++++++++++++++++
>> drivers/phy/qualcomm/phy-qcom-qmp.h | 4 +
>> 3 files changed, 151 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> index 41a1074..6061b6f 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
>> @@ -9,6 +9,7 @@ Required properties:
>> "qcom,ipq8074-qmp-pcie-phy" for PCIe phy on IPQ8074
>> "qcom,msm8996-qmp-pcie-phy" for 14nm PCIe phy on msm8996,
>> "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996,
>> + "qcom,msm8998-qmp-usb3-phy" for USB3 QMP V3 phy on msm8998,
>
> Please make bindings a separate patch. Combining patch 1 and 2
> binding changes is fine.
>
> Rob
>
Sure. Planning on re-spinning early next week to address a few comments.
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2019-01-11 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 16:50 [PATCH v1 4/6] phy: qcom-qmp: Add QMP V3 USB3 PHY support for msm8998 Jeffrey Hugo
2019-01-11 19:45 ` Rob Herring
2019-01-11 19:48 ` Jeffrey Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f38a7b-a761-c924-08ef-fc685f027561@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).