From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4904C433E9 for ; Thu, 11 Mar 2021 21:11:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C5AE64F8B for ; Thu, 11 Mar 2021 21:11:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230430AbhCKVLN convert rfc822-to-8bit (ORCPT ); Thu, 11 Mar 2021 16:11:13 -0500 Received: from mga04.intel.com ([192.55.52.120]:25630 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbhCKVKV (ORCPT ); Thu, 11 Mar 2021 16:10:21 -0500 IronPort-SDR: 12hnibvAz7Y0NkCxSxQ75t/LVqKnmuTqo3wRKW9gLlszUJCwcYSG0avBxkNCKlKUELd06D3End bv4akPThLX+A== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="186365297" X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="186365297" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 13:10:03 -0800 IronPort-SDR: mNiYVKGfY6eQo3jt5dbwy+56rw5oM3B4WkCSPVJ27Z8X+/skd4U4rzZXQbrYP15hcCxDI22IZp P630yyLhWN4A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="589353470" Received: from irsmsx602.ger.corp.intel.com ([163.33.146.8]) by orsmga005.jf.intel.com with ESMTP; 11 Mar 2021 13:10:00 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by irsmsx602.ger.corp.intel.com (163.33.146.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 11 Mar 2021 21:09:59 +0000 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2106.013; Thu, 11 Mar 2021 13:09:57 -0800 From: "Luck, Tony" To: Peter Zijlstra , "Liang, Kan" CC: Andi Kleen , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "acme@kernel.org" , "tglx@linutronix.de" , "bp@alien8.de" , "namhyung@kernel.org" , "jolsa@redhat.com" , "yao.jin@linux.intel.com" , "alexander.shishkin@linux.intel.com" , "Hunter, Adrian" , Mark Rutland , Ricardo Neri Subject: RE: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support Thread-Topic: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support Thread-Index: AQHXFrfRS7+fP1DgV0u9rghYd88t86p/RY4w Date: Thu, 11 Mar 2021 21:09:57 +0000 Message-ID: References: <1615394281-68214-1-git-send-email-kan.liang@linux.intel.com> <1615394281-68214-21-git-send-email-kan.liang@linux.intel.com> <01176076-049b-0129-4865-8c49cd002060@linux.intel.com> <20210311195832.GK4746@worktop.programming.kicks-ass.net> <400dbd6e-389c-899d-6d11-14b5a8f8f90e@linux.intel.com> <20210311204742.GM4746@worktop.programming.kicks-ass.net> In-Reply-To: <20210311204742.GM4746@worktop.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I think the "sapphire_rapids" is the code name for the server platform. > > If that's really the case, then: > > #define INTEL_FAM6_SAPPHIRERAPIDS_X 0x8F > > is wrong, those things should be uarch name, not platform name. Tony? 0x8F is the model number of the CPU that is named Sapphire Rapids that goes into the Eagle Stream platform If you want a uarch name, that might be the name of the core (.... something-cove ... I can't keep track of the names of all the coves). But that would likely lead to different confusion later if that *cove core is used in some other CPU model number that doesn't neatly fit into our _X, _L etc. suffix scheme) -Tony