From: Hans de Goede <hdegoede@redhat.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Bluez mailing list <linux-bluetooth@vger.kernel.org>,
linux-serial@vger.kernel.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
stable <stable@vger.kernel.org>,
Leif Liddy <leif.linux@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
Daniel Drake <drake@endlessm.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
matadeen@qti.qualcomm.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version
Date: Fri, 23 Feb 2018 08:14:28 +0100 [thread overview]
Message-ID: <a6090910-7941-b194-c094-7ce3ef047974@redhat.com> (raw)
In-Reply-To: <20180223031216.GA230265@rodete-desktop-imager.corp.google.com>
Hi,
On 23-02-18 04:12, Brian Norris wrote:
> Hi Hans,
>
> Sorry if I'm a little slow to follow up here. This hasn't been my
> top priority...
>
> On Mon, Feb 19, 2018 at 11:17:24AM +0100, Hans de Goede wrote:
>> On 16-02-18 18:59, Brian Norris wrote:
>>> On Fri, Feb 16, 2018 at 01:10:20PM +0100, Hans de Goede wrote:
>>>> Ok, I've asked the reporter of:
>>>>
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1514836
>>>
>>> Are you even sure that this reporter is seeing the original symptom at
>>> all (BT loses power, and therefore firmware)? Their report shows them
>>> running 4.15, which had this commit:
>>>
>>> fd865802c66b Bluetooth: btusb: fix QCA Rome suspend/resume
>>>
>>> which is admittedly completely broken. It breaks even perfectly working
>>> BT/USB devices, like mine. That's where I first complained, and we got
>>> this into 4.16-rc1:
>>>
>>> 7d06d5895c15 Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"
>>>
>>> Isn't it possible your reporter has no further problem, and none if this
>>> is actually important to them? I'd just caution you to be careful before
>>> assuming you need to add blacklist info for their DMI...
>>
>> Thanks, that is a good question. His problems only started when I
>> enabled usb-autosuspend by default for btusb devices and he got things
>> working by adding "btusb.enable_autosuspend=n" on the kernel commandline,
>> so he was not hitting the firmware loading race introduced by
>> fd865802c66b and runtime suspend/resume is really broken for him.
>
> Hmm? I'm not sure I completely follow here when you say "he was not
> hitting the firmware loading race". If things were functioning fine with
> system suspend (but not with autosuspend), then he's not seeing the
> controller (quoting commit fd865802c66b) "losing power during suspend".
He was running a kernel with the original "fd865802c66b Bluetooth: btusb:
fix QCA Rome suspend/resume" commit, which fixes regular suspend for
devices which are "losing power during suspend", but does nothing for
runtime-suspend.
He ran tests both with and without runtime-pm enabled with that same kernel
and he needed to disable runtime-pm to get working bluetooth.
> So, that would suggest he could only be seeing the race (as I was), and
> that his machine does not deserve a RESET_RESUME quirk?
I hope my above answer helps to clarify why I believe the quirk is
necessary on his machine.
Regards,
Hans
>
> Or maybe I'm really misunderstanding.
>
>>> As I read it, you need to investigate who are the "numerous reported
>>> instances" that generated commit fd865802c66b in the first place. That's
>>> where this mess started, IIUC. >
>>> But otherwise, yes, option 3 sounds OK. FWIW, my systems are ARM based
>>> and don't have DMI data, so option 2 wouldn't work.
>>
>> Right I think we all agree that the new plan now is to go back to
>> QCA behaving normally wrt (runtime) suspend/resume and then set the
>> USB-core RESET_RESUME quirk (which does not have the firmware
>> loading race) based on a DMI blacklist.
>>
>> I only have the one report for which I will write a patch implementing
>> this new policy soonish. And Kai-Heng Feng has another report which
>> might even be the machine. I certainly would not be surprised if it
>> is another Lenovo machine.
>
> It seems like you folks moved forward on that one. Thanks.
>
> Brian
>
next prev parent reply other threads:[~2018-02-23 7:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180108094416.4789-1-hdegoede@redhat.com>
2018-02-13 2:24 ` [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version Brian Norris
2018-02-13 11:25 ` Hans de Goede
2018-02-16 2:27 ` Brian Norris
2018-02-16 3:23 ` Guenter Roeck
2018-02-16 8:26 ` udev USB autosupend whitelist (was Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version) Hans de Goede
2018-02-16 16:49 ` Brian Norris
2018-02-19 14:59 ` Hans de Goede
2018-02-16 8:43 ` [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version Marcel Holtmann
2018-02-16 8:56 ` Hans de Goede
2018-02-16 11:45 ` Marcel Holtmann
2018-02-16 12:10 ` Hans de Goede
2018-02-16 17:59 ` Brian Norris
2018-02-19 10:17 ` Hans de Goede
2018-02-23 3:12 ` Brian Norris
2018-02-23 7:14 ` Hans de Goede [this message]
2018-02-27 2:29 ` Brian Norris
2018-02-27 14:07 ` Hans de Goede
2018-02-28 10:54 ` Hans de Goede
2018-03-09 0:56 ` Leif Liddy
2018-03-10 2:42 ` Leif Liddy
2018-02-18 8:13 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6090910-7941-b194-c094-7ce3ef047974@redhat.com \
--to=hdegoede@redhat.com \
--cc=briannorris@chromium.org \
--cc=drake@endlessm.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=leif.linux@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcel@holtmann.org \
--cc=matadeen@qti.qualcomm.com \
--cc=mka@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).